Bug 192037 - net-mgmt/smokeping: AnotherDNS plugin broken
Summary: net-mgmt/smokeping: AnotherDNS plugin broken
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Rodrigo Osorio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-22 14:47 UTC by Mark Felder
Modified: 2014-07-23 22:58 UTC (History)
1 user (show)

See Also:

Attachments
Patch for AnotherDNS.pm (1.49 KB, patch)
2014-07-22 14:47 UTC, Mark Felder 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Felder freebsd_committer freebsd_triage 2014-07-22 14:47:56 UTC 
Created attachment 144877 [details]
Patch for AnotherDNS.pm

AnotherDNS plugin is broken with modern Net::DNS. I've filed a bug upstream and sent a pull request but haven't heard back from Tobias yet.

https://github.com/oetiker/SmokePing/pull/22


Attached diff fixes it for our users.
Comment 1 John Marino freebsd_committer freebsd_triage 2014-07-22 15:23:40 UTC 
Hi Feld, you could assigned this directly I think.
Comment 2 Rodrigo Osorio freebsd_committer freebsd_triage 2014-07-22 20:52:49 UTC 
Hard-coding the value this way works, but PACKETSZ is in fact a constant declared in  Net::DNS::Resolver::Base and can be used that way :

$ready->recv( $buf, Net::DNS::Resolver::Base::PACKETSZ);

Can you try this option and give me a feedback asap ?

Cheers.
Comment 3 Mark Felder freebsd_committer freebsd_triage 2014-07-22 21:03:59 UTC 
Is Net::DNS::Resolver::Base::PACKETSZ part of the documented API? I haven't investigated; just checking. Wouldn't want to get us into the same situation down the road.

I'll test ASAP.
Comment 4 Mark Felder freebsd_committer freebsd_triage 2014-07-22 21:13:08 UTC 
Yes this appears to be working.
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-07-23 13:42:09 UTC 
A commit references this bug:

Author: rodrigo
Date: Wed Jul 23 13:41:08 UTC 2014
New revision: 362694
URL: http://svnweb.freebsd.org/changeset/ports/362694

Log:
  Fix a minima the plugin breakage introduced by Net::DNS 0.75 and above.
  This bug is complex and must be fixed upstream (smokeping)[1].
  [1] https://rt.cpan.org/Public/Bug/Display.html?id=96479

  PR:		ports/192037
  Submitted by:	feld
  Reviewed by:	rodrigo (maintainer)
  Approved by:	kwm (mentor)
  MFH:		2014Q3

Changes:
  head/net-mgmt/smokeping/Makefile
  head/net-mgmt/smokeping/files/patch-lib__Smokeping__probes__AnotherDNS.pm
Comment 6 Rodrigo Osorio freebsd_committer freebsd_triage 2014-07-23 22:58:22 UTC 
commited with minor changes

thanks