Created attachment 144886 [details] patch to net/delegate/Makefile During some of the latest updates to net/delegate, the binary checksumming features seems to have been mishandled. On my system, this leads to delegate refusing to start. Attached is a patch which restores binary checksumming. In addition, it allows to set the ADMIN variable (e.g., in /etc/make.conf) to a suitable, site-local value, and otherwise proposes a reasonable default for it. /etc/make.conf could contain something along the lines: .if ${.CURDIR:M*/net/delegate} ADMIN=hostmaster@mail.xyzzy .endif This will override the port's default setting (see the patch). The build has been tested on releng/9.2 and release/10.0.0, both i386 and amd64. Running has been tested on releng/9.2 i386. -- Martin
over to maintainer
A commit references this bug: Author: danilo Date: Tue Jul 22 19:01:20 UTC 2014 New revision: 362568 URL: http://svnweb.freebsd.org/changeset/ports/362568 Log: - Don't strip the binary. This breaks the binary checksumming - Introduce ADMIN variable PR: ports/192039 Submitted by: Martin Birgmeier <la5lbtyi@aon.at> Changes: head/net/delegate/Makefile
This patch reintroduced the problem solved by danfe@. Seems the problem is not related to STRIP. I'm proposing revert (partially) the commit and re-sign the binary after the staging step. Is that acceptable for you? +post-install: +# Re-sign the executable + @${CP} ${STAGEDIR}${PREFIX}/sbin/delegated ${WRKDIR}/tmp/dg + @${CHMOD} +w ${STAGEDIR}${PREFIX}/sbin/delegated + @${WRKDIR}/tmp/dg -Fesign -w ${STAGEDIR}${PREFIX}/sbin/delegated + @${CHMOD} -w ${STAGEDIR}${PREFIX}/sbin/delegated +
Build log: https://redports.org/buildarchive/20140722202900-37564/ New Makefile: https://redports.org/browser/daniloegea/net/delegate/Makefile
A commit references this bug: Author: danilo Date: Tue Jul 22 21:05:32 UTC 2014 New revision: 362580 URL: http://svnweb.freebsd.org/changeset/ports/362580 Log: - Fix the binary checksumming (use this approach until find a better solution) - Fix staging PR: ports/192039 Changes: head/net/delegate/Makefile
I think this method is also o.k., although it might break later should the upstream authors decide to rearrange their build logic. However, could you please explain what was the problem solved by danfe@? (The subversion log unfortunately is too sparse.) - In my builds, using my version of the Makefile, I did not really notice any problem. -- Martin
The problem is that no port/package should touch files outside of the $WRKDIR. Delegate creates files relative to DGROOT (which defaults to $HOME AFAIR) when being run, and it runs itself during the build. Now, it doesn't do any real harm and probably goes unnoticed when the port is built normally, but breaks automated build robots such as tinderbox [1], for example. Explicitly setting DGROOT to ${WRKDIR} (that's basically what my patching with sed(1) does) allows it to package successfully. It does not affect the build in any other way (hopefully). [1] http://tinderbox.marcuscom.com/
Fixed. Thanks!