Bug 192127 - [PATCH] www/mod_geoip2 Permit Build for Apache 2.4
Summary: [PATCH] www/mod_geoip2 Permit Build for Apache 2.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-26 05:56 UTC by John Marshall
Modified: 2014-08-13 20:30 UTC (History)
2 users (show)

See Also:

Attachments
Patch Makefile to allow build with apache24 (404 bytes, patch)
2014-07-26 05:56 UTC, John Marshall 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Marshall 2014-07-26 05:56:25 UTC 
Created attachment 144990 [details]
Patch Makefile to allow build with apache24

The port's Makefile includes USE_APACHE=22 which means that bsd.apache.mk won't allow it to be built for Apache 2.4.

MaxMind's website indicates that the module is provided for Apache 2 and makes explicit reference to people using the module with Apache 2.4

  http://dev.maxmind.com/geoip/legacy/mod_geoip2/

The attached patch modifies the Makefile to USE_APACHE=22-24. I have built and tested the module on FreeBSD/i386 10-STABLE under Apache 2.4.10.
Comment 1 John Marino freebsd_committer freebsd_triage 2014-07-26 06:54:35 UTC 
notify maintainer for approval
Comment 2 John Marino freebsd_committer freebsd_triage 2014-08-11 08:55:21 UTC 
This PR timed out, maintain approval no longer required.  Anybody can commit this now.
Comment 3 commit-hook freebsd_committer freebsd_triage 2014-08-13 20:29:08 UTC 
A commit references this bug:

Author: marino
Date: Wed Aug 13 20:28:07 UTC 2014
New revision: 364807
URL: http://svnweb.freebsd.org/changeset/ports/364807

Log:
  www/mod_geoip2: Enable module to build on Apache24

  The main site indicates that module works with Apache 2.4 and the
  submitted has tested it on FreeBSD 10/i386

  PR:		192127
  Submitted by:	John Marshall
  Approved by:	maintainer timeout (3 weeks)

Changes:
  head/www/mod_geoip2/Makefile
Comment 4 John Marino freebsd_committer freebsd_triage 2014-08-13 20:30:27 UTC 
done!