Bug 192165 - [patch] lang/polyml fixes: depend on ffi for ffi support, use pkg-plist, add motif option
Summary: [patch] lang/polyml fixes: depend on ffi for ffi support, use pkg-plist, add ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-27 14:20 UTC by Steve Wills
Modified: 2014-07-31 18:44 UTC (History)
2 users (show)

See Also:

Attachments
polyml cleanup patch (1.81 KB, patch)
2014-07-27 14:20 UTC, Steve Wills 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Wills freebsd_committer freebsd_triage 2014-07-27 14:20:51 UTC 
Created attachment 145030 [details]
polyml cleanup patch

Hi,

The recent change to polyml adds support for system ffi but doesn't depend on it. Additionally, there's the "libtools:keepla" USES option, but that doesn't seem needed, simple "libtools" should work. Also, the recommendation is to use a pkg-plist file when there are more than 5 files in a package. This patch fixes those things and also adds the motif option, as well as removing the unnecessary USE_GCC option. See attached, and let me know if this breaks anything.

Thanks,
Steve
Comment 1 John Marino freebsd_committer freebsd_triage 2014-07-27 15:07:39 UTC 
notify maintainer for approval
Comment 2 Timothy Beyer 2014-07-27 21:29:54 UTC 
I just tried this patch and it works properly with "portlint -CA" and at runtime.  I approve.
Comment 3 Timothy Beyer 2014-07-27 21:29:54 UTC 
I just tried this patch and it works properly with "portlint -CA" and at runtime.  I approve.
Comment 4 John Marino freebsd_committer freebsd_triage 2014-07-31 18:14:17 UTC 
Let Steve have the honors...
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-07-31 18:43:41 UTC 
A commit references this bug:

Author: swills
Date: Thu Jul 31 18:43:36 UTC 2014
New revision: 363649
URL: http://svnweb.freebsd.org/changeset/ports/363649

Log:
  lang/polyml: depend on ffi, use pkg-plist, add motif option

  PR:		192165
  Approved by:	Timothy Beyer <beyert@cs.ucr.edu> (maintainer)

Changes:
  head/lang/polyml/Makefile
  head/lang/polyml/pkg-plist
Comment 6 Steve Wills freebsd_committer freebsd_triage 2014-07-31 18:44:09 UTC 
Committed!