Bug 192381 - devel/glib20 option COLLATION_FIX is poorly described
Summary: devel/glib20 option COLLATION_FIX is poorly described
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-04 15:12 UTC by Ed Maste
Modified: 2016-07-26 00:17 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Maste freebsd_committer freebsd_triage 2014-08-04 15:12:19 UTC 
COLLATION_FIX defaults to off, and has as its description:
COLLATION_FIX_DESC=    fix string collation

This is completely unclear for an end-user.  Does leaving it disabled (default) result in a glib with broken string collation?

Spelunking in the Makefile's history shows it was first introduced in r171239, which gives more context:
http://svnweb.freebsd.org/ports?view=revision&revision=171239

> Fix string collation by using the icu library, since the FreeBSD libc
> does not support UTF-8 collation.
Comment 1 John Marino freebsd_committer freebsd_triage 2014-08-04 15:19:23 UTC 
over to maintainer group...
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-07-26 00:11:16 UTC 
A commit references this bug:

Author: jbeich
Date: Tue Jul 26 00:10:36 UTC 2016
New revision: 419085
URL: https://svnweb.freebsd.org/changeset/ports/419085

Log:
  devel/glib20: reword COLLATION_FIX description

  While not necessary on FreeBSD 11.0 anymore it maybe useful for debugging.

  PR:		192381
  Reported by:	emaste
  Approved by:	portmgr blanket

Changes:
  head/devel/glib20/Makefile
Comment 3 Jan Beich freebsd_committer freebsd_triage 2016-07-26 00:15:06 UTC 
Thanks. Improved. _DESC lines appear to have a character limit in dialog menu. ;\
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-07-26 00:17:18 UTC 
A commit references this bug:

Author: jbeich
Date: Tue Jul 26 00:16:43 UTC 2016
New revision: 419086
URL: https://svnweb.freebsd.org/changeset/ports/419086

Log:
  MFH: r419085

  devel/glib20: reword COLLATION_FIX description

  While not necessary on FreeBSD 11.0 anymore it maybe useful for debugging.

  PR:		192381
  Reported by:	emaste
  Approved by:	portmgr blanket
  Approved by:	ports-secteam blanket

Changes:
_U  branches/2016Q3/
  branches/2016Q3/devel/glib20/Makefile