Created attachment 145577 [details] diff -ruN Major version update.
files directory should be removed. Patches incorporated in distribution Makefile.
This isn't right, MANCOMPRESSED is no longer used. As this is a high-priority staging PR, before you submit a new version, can you provide verification? In order of preference, examples of what I'm looking for are: 1) "poudriere testport" or "poudriere bulk -t" logs 2) Redports or tinderbox logs 3) "make check-plist" followed by "make stage-qa" output (https://www.freebsd.org/doc/en/books/porters-handbook/porting-testing.html)
Created attachment 145592 [details] diff -x files -ruN
Created attachment 145593 [details] poudriere testport i386
Created attachment 145594 [details] poudriere testport amd64
everything looks fine except this stage-qa warning: ====> Running Q/A tests (stage-qa) Warning: 'bin/ephemera' is not stripped consider using ${STRIP_CMD} ====> Checking for pkg-plist issues (check-plist) I checked the port and it's used the vendor makefile to install. One solution for the above is use "${BSD_INSTALL_PROGRAM} <original patch> <copy-to-patch>" rather than "cp" or "install" or whatever. BSD_INSTALL_PROGRAM is an environmental variable set during "do-install" target. The less pretty way is use a post-install target e.g. post-install: ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/ephemera Note that STRIP_CMD is disabled when WITH_DEBUG is set.
Created attachment 145596 [details] diff -x files -ruN
Created attachment 145597 [details] poudriere testport amd64
Created attachment 145598 [details] poudriere testport i386
New distfile adds -s to vendor Makefile install to strip binary. Corrected: Port used SQLITE_USE instead of USE_SQLITE. New poudriere logs attached.
thanks for the update! moving to patch-ready status.
A commit references this bug: Author: marino Date: Sun Aug 10 13:25:20 UTC 2014 New revision: 364537 URL: http://svnweb.freebsd.org/changeset/ports/364537 Log: www/ephemera: Upgrade version 2.9 => 4.0 Also fix incorrect use of @sample keyword PR: 192532 Submitted by: maintainer (James Bailie) Changes: head/www/ephemera/Makefile head/www/ephemera/distinfo head/www/ephemera/files/ head/www/ephemera/pkg-descr head/www/ephemera/pkg-plist
I'm not sure why I thought this was a staging PR. That mistake bumped you to the front of the line. :) Some advice: 1) The patch having a prefix of "/usr/local/poudriere/ports/default/" was a bother, next time start with "www". 2) Don't tell people to manually remove files, include those removals in the patch. It makes it a lot easier for the committer. Thanks, John
Acknowledged: In future, patch path should start with category directory. Patch should remove files if necessary. Did not know how to get patch to remove files. Was not reading info diff, but man diff. man diff and info diff conflict on -E option (--remove-empty-files). Now I know.
i think the "remove empty files" applies to the program patch rather than diff. "svn patch" will do the right thing, removing zero-length files and empty directories. Anyway, this should do it: diff -u files/iwanttodeletethis.patch /dev/null > mygreat.diff