Bug 192579 - multimedia/ffmpeg does no longer build the V4L2 input device
Summary: multimedia/ffmpeg does no longer build the V4L2 input device
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Thomas Zander
URL:
Keywords:
Depends on: 193150 193151
Blocks:
  Show dependency tree / graph
 
Reported: 2014-08-11 13:44 UTC by Hans Petter Selasky
Modified: 2014-08-31 10:58 UTC (History)
2 users (show)

See Also:

Attachments
Fix build of V4L2 support in FFMPEG (1.54 KB, patch)
2014-08-28 08:49 UTC, Hans Petter Selasky 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Petter Selasky freebsd_committer freebsd_triage 2014-08-11 13:44:03 UTC 
Solution:

Revert this:

-check_header linux/fb.h
-check_header linux/videodev.h
-check_header linux/videodev2.h
-check_code cc linux/videodev2.h "struct v4l2_frmsizeenum vfse; vfse.discrete.width = 0;" && enable_safe struct_v4l2_frmivalenum_discrete
+#check_header linux/fb.h
+#check_header linux/videodev.h
+#check_header linux/videodev2.h
+#check_code cc linux/videodev2.h "struct v4l2_frmsizeenum vfse; vfse.discrete.width = 0;" && enable_safe struct_v4l2_frmivalenum_discrete

 check_header sys/videoio.h


And substitute all occurences of sys_videoio_h with linux_videodev2_h in the configure script.

Then it works again.
Comment 1 John Marino freebsd_committer freebsd_triage 2014-08-11 14:51:26 UTC 
over to maintainer
Comment 2 Thomas Zander freebsd_committer freebsd_triage 2014-08-23 17:19:00 UTC 
Would you be able to provide a patch? Thanks!
Comment 3 Hans Petter Selasky freebsd_committer freebsd_triage 2014-08-24 17:43:27 UTC 
I'll see what I can do.

--HPS
Comment 4 Hans Petter Selasky freebsd_committer freebsd_triage 2014-08-28 08:49:21 UTC 
Created attachment 146437 [details]
Fix build of V4L2 support in FFMPEG
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-08-30 07:47:38 UTC 
A commit references this bug:

Author: riggs
Date: Sat Aug 30 07:47:32 UTC 2014
New revision: 366591
URL: http://svnweb.freebsd.org/changeset/ports/366591

Log:
  - Restore V4L2 interface

  PR:		192579
  Submitted by:	hselasky@FreeBSD.org

Changes:
  head/multimedia/ffmpeg/Makefile
  head/multimedia/ffmpeg/files/patch-configure
Comment 6 Jan Beich freebsd_committer freebsd_triage 2014-08-30 15:54:22 UTC 
(In reply to Hans Petter Selasky from comment #0)
> And substitute all occurences of sys_videoio_h with linux_videodev2_h in the
> configure script.

Why does this matter if dependency ends with |_any|? sys/videoio.h is part of video(4) or v4l2 on netbsd/openbsd.
Comment 7 Hans Petter Selasky freebsd_committer freebsd_triage 2014-08-31 10:58:04 UTC 
This does not matter and was not done, except for removing the dependency for V4L2 driver.

--HPS