Created attachment 145890 [details] add staging support Add staging to irc/undernet-ircu and take maintainer. New files: files/pkg-message.in pkg-plist poudriere testport logs at: http://poudriere.dan.tm/latest-per-pkg/undernet-ircu/2.10.12.14_1/
tested staging PR, moving to patch-ready
You're rapidly gaining a reputation with me, I'll take your PR over somebody elses because of their testing and quality. - don't forget to run portlint as well. On this particular PR, you added a pkg-message (good) but didn't remove the post-install echo (redundant, unnecessary). The new functionality will display pkg-message automatically. If you look at your logs, you'll see the message twice.
another tip: If possible, use "\" separators to wrap lines that exceed 80 columns
this port would benefit heavily from the configuration capability of options ( https://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html ) addendum: actually, these options are backwards! Rather than "disable" the option, it should be "enable" but set by default. right? It makes the makefile a lot shorter and clearer.
hmmm yes.. give me a little while and i'll drop in a new diff with all the changes and a neater Makefile etc :-)
this one is really obscure: The PROFILE option needs to controlled by the make.conf variable "NO_PROFILE". It's a global thing and can't shouldn't be controlled by options.
(In reply to Daniel Austin from comment #5) > hmmm yes.. give me a little while and i'll drop in a new diff with all the > changes and a neater Makefile etc :-) No, not yet, I'm working on it myself.
I'll attach makefile before committing
ok no problem, i'll wait :)
Another tip: rather than three MKDIR commands, use one command with 3 arguments. I generally wrap to put one directory per line, indented, but that varies.
another tip: eliminate loops when unnecessary, see my DOCS rework when it comes
i just noticed this, you don't need ${MKDIR} ${STAGEDIR}${DOCSDIR} ${STAGEDIR}${DOCSDIR}/api MKDIR = mkdir -p so the first one will be created when you create the second one. So you can omit the first one.
We remove AUTHOR lines from pkg-descr when we find them now.
Created attachment 145906 [details] Reworks (intermediate?) version Here's the current version. However, I personally disagree with creating a pkg-plist version. I'd rather use PORTDOCS=* which removes all the PORTSDOCS entries from pkg-plist which then makes it so small we can embed it into the Makefile. What do you think?
actually that made me notice that your PORTEXAMPLES is wrong. PORTEXAMPLES refers to files specifically located in %%EXAMPLESDIR%% not %%ETCDIR%% so we need to change that.
Hi John, I'm happy with that (and your comment about PORTDOCS) - and thanks for the advice.
Created attachment 145909 [details] Final version Okay so this is the final version.
A commit references this bug: Author: marino Date: Sun Aug 17 09:36:48 UTC 2014 New revision: 365163 URL: http://svnweb.freebsd.org/changeset/ports/365163 Log: Stage irc/undernet-ircu and assign maintainership to submitter Big changes include moving ircd from bin to sbin and installing lots of documentation. Also "disable" options were swapped to "enable" options and turned on by default. PR: 192720 Submitted by: Daniel Austin Add'l work by: marino Changes: head/irc/undernet-ircu/Makefile head/irc/undernet-ircu/files/pkg-message.in head/irc/undernet-ircu/files/undernet.in head/irc/undernet-ircu/pkg-descr
Great, hopefully all those tips and reworks were illustrative!
(In reply to John Marino from comment #19) > Great, hopefully all those tips and reworks were illustrative! They were useful, thanks :)