Comment 1 John Marino 2014-08-26 12:52:42 UTC

Thanks!  Do you have any verification available?  In order of preference, examples of what I'm looking for are:

1) "poudriere testport" or "poudriere bulk -t" logs
2) Redports or tinderbox logs
3) "make check-plist" followed by "make stage-qa" output  (https://www.freebsd.org/doc/en/books/porters-handbook/porting-testing.html)



It looks ok though.  verification would confirm.

Created attachment 146311 [details]
poudriere testport -o local/logstash-forwarder -j 10amd64 output

BUILD_DEPENDS=  go:${PORTSDIR}/lang/go (missing tab)
My custom ports are in local/ and poudriere testport complains but it should be OK if put in the proper (sysutils) folder.

Comment 3 John Marino 2014-08-26 15:43:02 UTC

can you clean up the fatal portlint error?  (new shar)

FATAL: Makefile: [12]: use a tab (not space) after a variable name

then I'll move it to match ready

Created attachment 146317 [details]
Shar archive

Fixed tab.

Comment 5 John Marino 2014-08-26 17:57:21 UTC

ok, moving to patch-ready

Comment 6 commit-hook 2014-09-05 20:51:49 UTC

A commit references this bug:

Author: cs
Date: Fri Sep  5 20:50:49 UTC 2014
New revision: 367389
URL: http://svnweb.freebsd.org/changeset/ports/367389

Log:
  I'm a lumberjack and I'm ok! I sleep when idle, then I ship logs all day!
  I parse your logs, I eat the JVM agent for lunch!

  (This project was recently renamed from 'lumberjack' to 'logstash-forwarder' to
  make its intended use clear. The 'lumberjack' name now remains as the network
  protocol, and 'logstash-forwarder' is the name of the program. It's still the
  same lovely log forwarding program you love.)

  WWW: https://github.com/elasticsearch/logstash-forwarder

  PR:		ports/193012
  Submitted by:	cheffo@freebsd-bg.org

Changes:
  head/sysutils/Makefile
  head/sysutils/logstash-forwarder/
  head/sysutils/logstash-forwarder/Makefile
  head/sysutils/logstash-forwarder/distinfo
  head/sysutils/logstash-forwarder/files/
  head/sysutils/logstash-forwarder/files/logstash-forwarder.in
  head/sysutils/logstash-forwarder/files/patch-fileinfo_freebsd.go
  head/sysutils/logstash-forwarder/files/patch-filestate_freebsd.go
  head/sysutils/logstash-forwarder/files/pkg-message.in
  head/sysutils/logstash-forwarder/pkg-descr
  head/sysutils/logstash-forwarder/pkg-plist

Comment 7 commit-hook 2014-09-05 20:56:50 UTC

A commit references this bug:

Author: cs
Date: Fri Sep  5 20:55:52 UTC 2014
New revision: 45549
URL: http://svnweb.freebsd.org/changeset/doc/45549

Log:
  Add new contributor

  PR:		193012

Changes:
  head/en_US.ISO8859-1/articles/contributors/contrib.additional.xml

Comment 8 Carlo Strub 2014-09-05 20:59:49 UTC

Committed with some reservations:

It is urgent that you use:

.include "${PORTSDIR}/lang/go/files/bsd.go.mk"

next time you update this port, because there is a high chance that this will be moved into Mk at some point and therefore your port will already follow the standards for go ports.

Comment 9 John Marino 2014-09-05 21:39:50 UTC

(In reply to Carlo Strub from comment #8)
> Committed with some reservations:
> 
> It is urgent that you use:
> 
> .include "${PORTSDIR}/lang/go/files/bsd.go.mk"
> 

Carlo, this is semi-bad advice.

Don't use "${PORTSDIR}" ever, use "${.CURDIR}/../.." instead

Comment 10 Carlo Strub 2014-09-06 07:24:34 UTC

Hmm. I didn't know about that John. Thanks for updating me on this.

Cheers,
Carlo

I'm fixing the port to use .include "${.CURDIR}/../../lang/go/files/bsd.go.mk"
and will also update it as there is an update from upstream. Should I fill new bug report or reuse this one?

Thanks.

Comment 12 John Marino 2014-09-08 12:46:09 UTC

Please re-use this one.

Comment 13 John Marino 2014-09-08 12:47:39 UTC

Disregard.
I see the port was already committed and there's already another PR.  

And the PR is closed.

So ignore what I just said.