Created attachment 146359 [details] patch: revert changes in pkg-plist - Revert changes in pkg-plist made by commiter. - Bump portrevision. 1. Main html doc should be unconditionally installed since CGI uses the BackupPC.html as a documentation page. 2. .sample files actually are templates for the configuration script and should not be installed as working configuration files.
https://redports.org/buildarchive/20140827071041-30592/
wg@ is CC'd already, but assigning him the PR since it appears the maintainer is questioning one of his commits.
Redports/tinderbox sucks. ====> Running Q/A tests (stage-qa) ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: %%ETCDIR%%/config.pl Error: Orphaned: %%ETCDIR%%/hosts ===> Checking for directories owned by MTREEs ===> Checking for directories handled by dependencies ===> Checking for items in pkg-plist which are not in STAGEDIR ===> Error: Plist issues found. *** Error code 1 Stop. make: stopped in /usr/ports/sysutils/backuppc ====>> Error: check-plist failures detected build of /usr/ports/sysutils/backuppc ended at Wed Aug 27 08:52:11 BRT 2014 build time: 00:00:14 ====>> Error: Build failed in phase: check-plist ====>> Cleaning up ====>> Umounting file systems
Created attachment 146479 [details] patch: revert changes in pkg-plist, remove config files from STAGEDIR I removed unneeded configuration files from STAGEDIR to avoid the thinderbox error. https://redports.org/buildarchive/20140829060933-09926/
A commit references this bug: Author: wg Date: Fri Aug 29 12:26:43 UTC 2014 New revision: 366504 URL: http://svnweb.freebsd.org/changeset/ports/366504 Log: sysutils/backuppc: revert a couple of changes - Main doc html is used by the application - sample files are actually templates for the configuration script PR: 193059 Submitted by: maintainer Changes: head/sysutils/backuppc/Makefile head/sysutils/backuppc/pkg-plist
Hi William, What reason do you have to delete "@dirrm %%DOCSDIR%%" from pkg-plist? Now the port leaves DOCSDIR on uninstall if it was built with WITHOUT="DOCS".
Because poudriere complains about duplicate docs entry if you don't. Relying on a file installed into portdocs is completely wrong. You should patch the software to install the file to /usr/local/share/${PORTNAME}
Created attachment 146529 [details] patch: Move CGI documentation to WWWDIR - Add separate copy of main documentation to WWWDIR - Bump portrevision https://redports.org/buildarchive/20140830115010-47871/
A commit references this bug: Author: wg Date: Sat Aug 30 16:46:18 UTC 2014 New revision: 366645 URL: http://svnweb.freebsd.org/changeset/ports/366645 Log: sysutils/backuppc: copy required html file to WWWDIR PR: 193059 Submitted by: maintainer Changes: head/sysutils/backuppc/Makefile head/sysutils/backuppc/files/patch-lib__BackupPC__CGI__View.pm head/sysutils/backuppc/pkg-plist