Created attachment 146502 [details] new port shar file Ccnet is a framework for writing networked applications in C. It provides the services of peer identification, connection management, service invocation, and message sending. Server has the management of user, group, and cluster.
Created attachment 146503 [details] test port log
Created attachment 146793 [details] new port shar file - Updated from 3.0.4 to 3.1.4, which is latest version. - Adding some fixes from ChilledHeart for some memory issues, and makefile issue. - Fixed the issue that desktop client can not connect to the server.
See bug 193132 for review items that also apply to the patch in this issue. Additionally: * Missing LICENSE_FILE * COMMENT: Indefinite article ("A") * GH_PROJECT defaults to ${PORTNAME} already, unnecessary. * Multiple USE_AUTOTOOLS lines, combine them * Typo: ACLOCL_ARGS * Empty AUTOHEADER_ARGS and AUTOCONF_ARGS * Adding --prefix to CONFIGURE_ARGS is unecessary * Incorrect pkgconfig .pc file location (lib -> libdata) (Use USES=pathfix) Please update your patch with all of the above changes along with those from bug 193132
Created attachment 146925 [details] diff to update shar file
Created attachment 146927 [details] updated shar file
Created attachment 146930 [details] portlint -AC output
Created attachment 147549 [details] for updated mk Based on Jason E. Hale <jhale@FreeBSD.org> 's comment on https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193132 (1) change the wrong Makefile.am patch. (2) fmt the pkg-descr within 72 col (3) clean the auto tool related issue.
again the post-install target commands are suppressed with "@". Remove those except for mkdir commands.
Created attachment 148938 [details] portlint -AC output The warning seems to result from portlint is not updated.
A) update portlint B) in this case it doesn't matter. @dir is not a new name for @dirrm. You are misusing it. (Or you are using make make-plist without editing the result) See /usr/ports/CHANGES about how to properly use @dir keyword. In most cases, you don't use it at all (99%) for directories.
Created attachment 148940 [details] uodated Shar file - remove "@" from all install commands. - pkg-plist changed to be updated.
Created attachment 148941 [details] test port log
Comment on attachment 148940 [details] uodated Shar file Don't forget to explicitly specify MIME as text/plain for shar files.
To state what I said previously another way, Remove all these lines from pkg-plist: X@dir include/ccnet X@dir %%PYTHON_SITELIBDIR%%/ccnet/async X@dir %%PYTHON_SITELIBDIR%%/ccnet X@dir %%PYTHON_SITELIBDIR%% X@dir %%PYTHON_LIBDIR%% X@dir %%WWWDIR%%/seafile/bin X@dir %%WWWDIR%%/seafile X@dir %%WWWDIR%% X@dir www/haiwen
(In reply to Jingfeng Yan from comment #12) > Created attachment 148941 [details] > test port log Are you sure you uploaded the latest shar? because I would have expected to see errors related to the "@dir" lines and I don't see those errors. Maybe you fixed the port but uploaded an old shar file.
(In reply to John Marino from comment #15) > (In reply to Jingfeng Yan from comment #12) > > Created attachment 148941 [details] > > test port log > > Are you sure you uploaded the latest shar? because I would have expected to > see errors related to the "@dir" lines and I don't see those errors. > > Maybe you fixed the port but uploaded an old shar file. Will change and test again.
(In reply to Jingfeng Yan from comment #16) > (In reply to John Marino from comment #15) > > (In reply to Jingfeng Yan from comment #12) > > > Created attachment 148941 [details] > > > test port log > > > > Are you sure you uploaded the latest shar? because I would have expected to > > see errors related to the "@dir" lines and I don't see those errors. > > > > Maybe you fixed the port but uploaded an old shar file. > > Will change and test again. > Maybe you fixed the port but uploaded an old shar file. pouderier only complain for usage of @dirrmtry, and suggest using @dir. It claims that @dirrmtry is deprecated and please use @dir. You are correct, the list are generated from makeplist. After I run makeplist again, I did see all the @dirrmtry are changed to be @dir. Then, pouderier did not complain any more. Only portlint complains.
(In reply to Jingfeng Yan from comment #17) > (In reply to Jingfeng Yan from comment #16) > > (In reply to John Marino from comment #15) > > > (In reply to Jingfeng Yan from comment #12) > > > > Created attachment 148941 [details] > > > > test port log > > > > > > Are you sure you uploaded the latest shar? because I would have expected to > > > see errors related to the "@dir" lines and I don't see those errors. > > > > > > Maybe you fixed the port but uploaded an old shar file. > > > > Will change and test again. > > > Maybe you fixed the port but uploaded an old shar file. > > pouderier only complain for usage of @dirrmtry, and suggest using @dir. It > claims that > @dirrmtry is deprecated and please use @dir. You are correct, the list are > generated from makeplist. After I run makeplist again, I did see all the > @dirrmtry are changed to be @dir. Then, pouderier did not complain any > more. Only portlint complains. 0922 is the special day :) 20140922: AUTHOR: bapt@FreeBSD.org pkg(8) now handles the directories under PREFIX automatically, and will automatically remove them as needed. A new @dir keyword has been introduced to handle directories specially: - directories with special owner, group, or permissions (access mode) - empty directories - directories out of PREFIX As a consequence @dirrm and @dirrmtry are now considered deprecated. Credentials can now be passed in arguments to keywords (the empty keyword means "regular file"): @(user,group,mode) file1 @dir(user,group,mode) directory_with_special_owner_or_mode PLIST_DIRSTRY is now considered deprecated, use PLIST_DIRS instead.
(In reply to Jingfeng Yan from comment #17) > pouderier only complain for usage of @dirrmtry, and suggest using @dir. It > claims that > @dirrmtry is deprecated and please use @dir. It is a misleading suggestion. The most likely fix for @dirrmtry is removing the line, not replacing it with @dir > You are correct, the list are generated from makeplist. using an unmodified makeplist output is a basically a user error. You are expected to modify it, *especially* the @dir lines. > After I run makeplist again, I did see all the > @dirrmtry are changed to be @dir. Then, pouderier did not complain any > more. Only portlint complains. Poudriere doesn't complain because the logic of either the makeplist or the check-plist isn't smart enough yet. Please remove the @dir as I mentioned above and run the tests again. They will pass without any @dir lines in the pkg-plist.
Created attachment 148967 [details] portlint -AC output
Created attachment 148968 [details] updated shar file removed all @dir s.
Created attachment 148969 [details] test port log
I am not sure about this, but this seems kind of old: XUSE_AUTOTOOLS= libtoolize aclocal autoheader automake autoconf XLIBTOOLIZE_ARGS=-i -c -f XACLOCAL_ARGS= -I m4 shouldn't this be using "USES+= autoreconf" instead of USE_AUTOTOOLS? I'm not the familiar with this autoreconf tool, are you?
i guess you used it in devel/libsearpc already...
(In reply to John Marino from comment #24) > i guess you used it in devel/libsearpc already... Yes.
(In reply to John Marino from comment #23) > I am not sure about this, but this seems kind of old: > > XUSE_AUTOTOOLS= libtoolize aclocal autoheader automake autoconf > XLIBTOOLIZE_ARGS=-i -c -f > XACLOCAL_ARGS= -I m4 > > > shouldn't this be using "USES+= autoreconf" instead of USE_AUTOTOOLS? > > I'm not the familiar with this autoreconf tool, are you? :) not so familiar with it. I need to verify this again. In early Sept, I thing there is some changes which make libtools and autoconf/reconf run correctly without adding further ARGS. Before that changes, the args is "must-have". I think I was half-cleaning all the ports. Some ports like libsearpc has been corrected.
Created attachment 148973 [details] updated shar file cleaned USE_AUTOTOOL
Created attachment 148974 [details] test port log
Created attachment 148976 [details] overall patch to 0922 Shar
I think it's patch-ready now. I'll take it myself.
hmmm, final question: Why is this on "www" category and not something like "net" or "net-mgmt" ? the description is "Ccnet is a framework for writing networked applications in C. It provides the services of peer identification, connection management, service invocation, and message sending. Server has the management of user, group, and cluster." I don't see where the "www" comes in. My guess is that this should be in "net-mgmt" category with a secondary category of "devel". What do you think?
I am going to go with that (primary in net-mgmt, secondary in devel)
A commit references this bug: Author: marino Date: Mon Nov 3 07:42:42 UTC 2014 New revision: 372097 URL: https://svnweb.freebsd.org/changeset/ports/372097 Log: Add new port net-mgmt/ccnet PR: 193133 Submitted by: Jingfeng Yan Ccnet is a framework for writing networked applications in C. It provides the services of peer identification, connection management, service invocation, and message sending. Server has the management of user, group, and cluster. Changes: head/net-mgmt/Makefile head/net-mgmt/ccnet/ head/net-mgmt/ccnet/Makefile head/net-mgmt/ccnet/distinfo head/net-mgmt/ccnet/files/ head/net-mgmt/ccnet/files/patch-configure.ac head/net-mgmt/ccnet/files/patch-lib_Makefile.am head/net-mgmt/ccnet/files/patch-lib_net.c head/net-mgmt/ccnet/files/patch-lib_utils.c head/net-mgmt/ccnet/files/patch-makefile.am head/net-mgmt/ccnet/files/patch-net_common_getgateway.c head/net-mgmt/ccnet/files/patch-net_common_processors_rcvcmd-proc.c head/net-mgmt/ccnet/files/patch-net_common_processors_service-proxy-proc.c head/net-mgmt/ccnet/files/patch-net_common_session.c head/net-mgmt/ccnet/pkg-descr head/net-mgmt/ccnet/pkg-plist
I'll make a note on the dependent ports that they need to be updated to reflect the new category. This PR is done!
(In reply to John Marino from comment #34) > I'll make a note on the dependent ports that they need to be updated to > reflect the new category. > > This PR is done! Okay. Thank you for your committing. Will use your suggestion of category for seafile.