Created attachment 146591 [details] add support for apache 2.4 The attached patch will allow suphp to run under apache 2.4 in the same way as it runs under 2.2. Added files: - files/patch-configure Poudriere testport logs at: http://poudriere.dan.tm/latest-per-pkg/suphp/0.7.2_2/ Info for maintainer: Whilst php-fpm is the preferred new method, it's not ideal for large shared hosting situations with hundreds of users and sites (having that many pools is very wasteful). I've been using suphp under 2.4 for over a year in a way that php-fpm could not service. No issues at all. So long as no major vulnerabilities show up, I think we should continue to maintain suphp in the ports tree (which means requiring 2.4 support now that it's the default apache version)
note: the BZ diff viewer isnt showing the full diff
Ok full poudriere testport logs are online now (sorry, my 10.0/amd64 builder was busy!)
tested patch to unbreak on Apache 24, sending over to maintainer (although I see now Bryan already knew about it)
Hi, any news on this?
still waiting for maintainer approval
(In reply to John Marino from comment #3) > tested patch to unbreak on Apache 24, sending over to maintainer (although I > see now Bryan already knew about it) What makes you think that? I only noticed this today.
Hi Bryan, I added you as CC when I opened the PR, you should've received copies of all the comments on here ;o Thanks, Dan.
(In reply to Daniel Austin from comment #7) > Hi Bryan, > > I added you as CC when I opened the PR, you should've received copies of all > the comments on here ;o > > > Thanks, > > Dan. I did, it was just lost in the noise.
Ah no problem - I didn't want to chase it as I know you're busy!
The provided patch does not build with apache24. libtool: compile: cc -DHAVE_CONFIG_H -I. -I../../src -I/usr/local/include/apache24 -O2 -pipe -I/usr/include -fstack-protector -fno-strict-aliasing -DSUPHP_PATH_TO_SUPHP=\"/usr/local/sbin/s uphp\" -O2 -pipe -I/usr/local/include -fstack-protector -fno-strict-aliasing -std=gnu89 -MT mod_suphp.lo -MD -MP -MF .deps/mod_suphp.Tpo -c mod_suphp.c -fPIC -DPIC -o .libs/mod_suphp.o In file included from mod_suphp.c:24: In file included from /usr/local/include/apache24/httpd.h:44: In file included from /usr/local/include/apache24/ap_config.h:25: /usr/local/include/apache24/ap_hooks.h:39:10: fatal error: 'apr.h' file not found #include "apr.h" ^ 1 error generated. *** [mod_suphp.lo] Error code 1 make[4]: stopped in /wrkdirs/usr/ports/www/suphp/work/suphp-0.7.2/src/apache 1 error
Hi Bryan, I noticed that started happening a few weeks after I submitted the patch (I think due to a apr1 update). Changing: CONFIGURE_ARGS= CFLAGS="${CFLAGS}" --with-apxs=${APXS} to CONFIGURE_ARGS= CFLAGS="${CFLAGS} -I/usr/local/include/apr-1" --with-apxs=${APXS} in Makefile fixes the issue. It seems that "apr-1-config --cflags" no longer includes that include folder for some reason. Let me know if you want me to do a new patch file. Thanks, Dan.
(In reply to Daniel Austin from comment #11) > Hi Bryan, > > I noticed that started happening a few weeks after I submitted the patch (I > think due to a apr1 update). > > Changing: > [...] Thanks, will try.
Oops, I meant "apr-1-config --includes". If I run it manually from the prompt, it gives me the correct " -I/usr/local/include/apr-1/" but if I do make within suphp it doesn't see it so I suspect some gnu configure strangeness perhaps. Either way, modifying the line in Makefile works and i've got a few machines running with it :) Thanks, Dan.
(In reply to Daniel Austin from comment #11) > Changing: > > CONFIGURE_ARGS= CFLAGS="${CFLAGS}" --with-apxs=${APXS} > > to > > CONFIGURE_ARGS= CFLAGS="${CFLAGS} -I/usr/local/include/apr-1" > --with-apxs=${APXS} This is not sufficient. It has some other issue now. I'll look into it in the next few days. Sorry for missing this PR for so long. /bin/sh ../../libtool --tag=CC --mode=compile cc -DHAVE_CONFIG_H -I. -I../../src -I/usr/local/include/apache24 -O2 -pipe -I/usr/include -fstack-protector -fno-strict-aliasing -DSU PHP_PATH_TO_SUPHP=\"/usr/local/sbin/suphp\" -O2 -pipe -I/usr/local/include -fstack-protector -fno-strict-aliasing -std=gnu89 -I/usr/local/include/apr-1 -MT mod_suphp.lo -MD -MP -MF .deps/m od_suphp.Tpo -c -o mod_suphp.lo mod_suphp.c libtool: compile: cc -DHAVE_CONFIG_H -I. -I../../src -I/usr/local/include/apache24 -O2 -pipe -I/usr/include -fstack-protector -fno-strict-aliasing -DSUPHP_PATH_TO_SUPHP=\"/usr/local/sbin/s uphp\" -O2 -pipe -I/usr/local/include -fstack-protector -fno-strict-aliasing -std=gnu89 -I/usr/local/include/apr-1 -MT mod_suphp.lo -MD -MP -MF .deps/mod_suphp.Tpo -c mod_suphp.c -fPIC -DP IC -o .libs/mod_suphp.o mod_suphp.c:47:25: error: expected ';' after top level declarator module MODULE_VAR_EXPORT suphp_module; ^
This is what I actually used: -CONFIGURE_ARGS= CFLAGS="${CFLAGS}" --with-apxs=${APXS} +CONFIGURE_ARGS= CFLAGS="${CFLAGS} -I`${LOCALBASE}/bin/apr-1-config --includedir`" --with-apxs=${APXS}
Created attachment 149569 [details] add support for apache 2.4 (revised)
Hi Bryan, I've updated the patch, and you'll see a 10.0/amd64 poudriere log in the original URL showing a successful build. Thanks, Dan.
Comment on attachment 149569 [details] add support for apache 2.4 (revised) Hi Bryan, poudriere testport logs for 8/9/10 (i386+amd64) now done at http://poudriere.dan.tm/latest-per-pkg/suphp/0.7.2_2/ from the new diff. Summary of diff: Modified: Makefile New files: files/patch-configure files/patch-configure.ac I'm happy to take over maintainer too if you wish, but i'll leave that up to you as it's your port :) Thanks, Dan.
Hi, thanks for the feedback. What would be the next step so that this actually reaches the ports tree? Thanks,
(In reply to vedad from comment #19) > Hi, thanks for the feedback. What would be the next step so that this > actually reaches the ports tree? > > Thanks, The patch still fails for me and I haven't had a chance to investigate why. If it works for you then apply it locally for now.
Any luck with this Bryan? I can't get it to error on any of my poudriere installations using testport (and i'm running it from my own package builder on apache 2.4 too) Thanks, Daniel.
Funny, I just opened this today to take another look. I don't know yet.
bump.
Note that only configure.ac is needed to be patched. That was the original problem with the original patch. It was patching configure and having it overwritten.
A commit references this bug: Author: bdrewery Date: Tue Jul 28 23:43:03 UTC 2015 New revision: 393137 URL: https://svnweb.freebsd.org/changeset/ports/393137 Log: Fix build with Apache 2.4. PR: 193200 Submitted by: Daniel Austin <freebsd-ports@dan.me.uk> Changes: head/www/suphp/Makefile head/www/suphp/files/patch-configure.ac
Thanks!
A commit references this bug: Author: bdrewery Date: Tue Jul 28 23:43:53 UTC 2015 New revision: 393138 URL: https://svnweb.freebsd.org/changeset/ports/393138 Log: MFH: r393137 Fix build with Apache 2.4. PR: 193200 Submitted by: Daniel Austin <freebsd-ports@dan.me.uk> Changes: _U branches/2015Q3/ branches/2015Q3/www/suphp/Makefile branches/2015Q3/www/suphp/files/patch-configure.ac