Bug 193229 - Update dns/mDNSResponder_nss to support config file, strip module correctly, etc
Summary: Update dns/mDNSResponder_nss to support config file, strip module correctly, etc
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-01 18:07 UTC by Matthieu Volat
Modified: 2014-09-20 17:41 UTC (History)
2 users (show)

See Also:

Attachments
Patch against current port tree (2.93 KB, patch)
2014-09-01 18:08 UTC, Matthieu Volat 		no flags Details | Diff
Patch (8char tabs) (2.98 KB, patch)
2014-09-04 18:12 UTC, Matthieu Volat 		no flags Details | Diff
Minimal patch (1.02 KB, patch)
2014-09-04 18:30 UTC, Matthieu Volat 		no flags Details | Diff
col wrapping restored (1.45 KB, patch)
2014-09-04 18:41 UTC, Matthieu Volat 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthieu Volat 2014-09-01 18:07:20 UTC 
Hi,

I am the maintainer of dns/mDNSResponder_nss and would like to have the attached patch commited which fixes a few things:
* manage config file (with sample according to the ports guidelines)
* fix stripping
* (fix indent in a few places)

It was tested successfully on redports:
https://redports.org/changeset/31318

Thanks,
Comment 1 Matthieu Volat 2014-09-01 18:08:04 UTC 
Created attachment 146632 [details]
Patch against current port tree
Comment 2 John Marino freebsd_committer freebsd_triage 2014-09-04 17:44:09 UTC 
Can you resubmit?  The tabs got messed up.  Make sure your editor is set to 8 spaces per tab.
Comment 3 Matthieu Volat 2014-09-04 18:12:02 UTC 
Created attachment 146812 [details]
Patch (8char tabs)

There. Are Makefile supposed to have 8char tabs?
Comment 4 John Marino freebsd_committer freebsd_triage 2014-09-04 18:15:41 UTC 
Always.  take a look at line 14 and 18 though.  There's an extra space in 14 and 18 is an unnecessary diff (some committers are really sensitive about unnecessary line changes)
Comment 5 John Marino freebsd_committer freebsd_triage 2014-09-04 18:16:01 UTC 
maybe this helps?
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=146812&action=diff
Comment 6 Matthieu Volat 2014-09-04 18:30:04 UTC 
Created attachment 146814 [details]
Minimal patch

Ok, thought it would be a good opportunity to improve readability, but here's a minimal patch that only manage the default and sample config file, and fix lib striping.
Comment 7 John Marino freebsd_committer freebsd_triage 2014-09-04 18:32:28 UTC 
(smile)

but the column wrapping was good!  and desired!
I was only mentioning the white space on the 2 specific lines.
Comment 8 Matthieu Volat 2014-09-04 18:41:17 UTC 
Created attachment 146815 [details]
col wrapping restored

ho, sorry, should be fine : only lines 14-18 reverted.
Comment 9 John Marino freebsd_committer freebsd_triage 2014-09-04 18:48:07 UTC 
that's enough torture for tonight; notifying maintainer in CC that this needs his approval.
Comment 10 Matthieu Volat 2014-09-04 19:01:26 UTC 
I'm the maintainer, so I guess I'll approve myself who was approved by you :)
Comment 11 Kubilay Kocak freebsd_committer freebsd_triage 2014-09-05 15:32:18 UTC 
Submitter is maintainer.
Comment 12 Matthieu Volat 2014-09-12 16:53:30 UTC 
Is anything still blocking the process? It's been a week since it was given green light...
Comment 13 commit-hook freebsd_committer freebsd_triage 2014-09-20 17:40:41 UTC 
A commit references this bug:

Author: pawel
Date: Sat Sep 20 17:40:38 UTC 2014
New revision: 368668
URL: http://svnweb.freebsd.org/changeset/ports/368668

Log:
  - Manage config file (with @sample according to the ports guidelines)
  - Fix stripping
  - Trim long lines

  PR:		ports/193229
  Submitted by:	maintainer

Changes:
  head/dns/mDNSResponder_nss/Makefile
  head/dns/mDNSResponder_nss/pkg-plist