Bug 193270 - editors/apel unbreak build with emacs-devel (24.4.50)
Summary: editors/apel unbreak build with emacs-devel (24.4.50)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
: 194908 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-09-03 02:17 UTC by Yoshiaki Kasahara
Modified: 2017-12-17 07:13 UTC (History)
5 users (show)

See Also:

Attachments
patch for files/patch-poe.el (611 bytes, patch)
2014-09-03 02:17 UTC, Yoshiaki Kasahara 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yoshiaki Kasahara 2014-09-03 02:17:32 UTC 
Created attachment 146702 [details]
patch for files/patch-poe.el

Building editors/apel is broken with EMACS_PORT_NAME=emacs-devel (24.4.50)

===>  Building for apel-emacs-devel-10.8_9
--- elc ---
/usr/local/bin/emacs-24.4.50 -batch -q -no-site-file -l APEL-MK -f compile-apel
 /wrkdirs/usr/ports/editors/apel/work/stage/usr/local /wrkdirs/usr/ports/editors
/apel/work/stage/usr/local/share/emacs/24.4.50/site-lisp /wrkdirs/usr/ports/edit
ors/apel/work/stage/usr/local/share/emacs/24.4.50/site-lisp
Loading /wrkdirs/usr/ports/editors/apel/work/apel-10.8/APEL-CFG...
Eager macro-expansion failure: (wrong-type-argument sequencep 769)
Eager macro-expansion failure: (wrong-type-argument sequencep 769)
Wrong type argument: sequencep, 769
*** [elc] Error code 255

make[1]: stopped in /wrkdirs/usr/ports/editors/apel/work/apel-10.8
1 error

make[1]: stopped in /wrkdirs/usr/ports/editors/apel/work/apel-10.8
===> Compilation failed unexpectedly.

There is a small patch available in a Debian package to fix the issue.
Please apply the attached patch to files/patch-poe.el
Comment 1 Tilman Keskinoz freebsd_committer freebsd_triage 2014-09-03 20:45:31 UTC 
over to maintainer
Comment 2 John Marino freebsd_committer freebsd_triage 2014-09-20 18:09:32 UTC 
PR is timed-out, so maintainer approval is no longer required.  Moving to "patch-ready" status.
Comment 3 NISHIMURA Takeshi 2014-11-06 06:20:16 UTC 
I think
        (or (not arglist) (not (listp arglist)))
is equivalent to
        (atom arglist)
?
If I am not misunderstanding..
Comment 4 Yoshiaki Kasahara 2014-11-06 08:19:27 UTC 
I had just borrowed an existing patch from Debian package, so I'm afraid that I have no idea how it fixed the problem...

I agree with you because (not arglist) is t when arglist is nil, and (not (listp arglist)) is t when arglist is not cons cell (= atom) nor nil.

I tried using (atom arglist) instead and it compiled fine by emacs-devel.
Comment 5 John Marino freebsd_committer freebsd_triage 2014-11-13 08:26:54 UTC 
Apparently this ticket was "taken" when I moved it to patch ready; it never made it to the general patch-ready pool.  fixing that now since it's desperately needed to unbreak the port.
Comment 6 John Marino freebsd_committer freebsd_triage 2014-11-13 08:27:45 UTC 
*** Bug 194908 has been marked as a duplicate of this bug. ***
Comment 7 commit-hook freebsd_committer freebsd_triage 2014-11-13 08:47:48 UTC 
A commit references this bug:

Author: marino
Date: Thu Nov 13 08:47:44 UTC 2014
New revision: 372512
URL: https://svnweb.freebsd.org/changeset/ports/372512

Log:
  editors/apel: Unbreak after EMACS update

  While here, pet portlint (fix comment, shorten pkg-descr)

  PR:		193270
  Submitted by:	Yoshiaki Kasahara
  Approved by:	maintainer timeout (2+ months)

Changes:
  head/editors/apel/Makefile
  head/editors/apel/files/patch-poe.el
  head/editors/apel/pkg-descr
Comment 8 John Marino freebsd_committer freebsd_triage 2014-11-13 08:49:02 UTC 
I just took it myself -- done.
Comment 9 vali gholami 2017-12-17 07:13:01 UTC 
MARKED AS SPAM