Bug 193324 - games/tuxpaint-config: Update to version 0.0.13
Summary: games/tuxpaint-config: Update to version 0.0.13
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-04 19:01 UTC by tkato432
Modified: 2014-09-21 12:06 UTC (History)
3 users (show)

See Also:

Attachments
games_tuxpaint-config.diff (9.79 KB, patch)
2014-09-04 19:01 UTC, tkato432 		no flags Details | Diff
games_tuxpaint-config.log (870 bytes, text/x-log)
2014-09-06 19:12 UTC, tkato432 		no flags Details
games_tuxpaint-config.diff (11.45 KB, patch)
2014-09-08 18:30 UTC, tkato432 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description tkato432 2014-09-04 19:01:36 UTC 
Created attachment 146823 [details]
games_tuxpaint-config.diff
Comment 1 Marcus von Appen freebsd_committer freebsd_triage 2014-09-05 21:59:17 UTC 
Can you please provide some more information about the test of the port, by either

a) providing the logs of a "poudriere testport" or "poudriere bulk -t" run OR
b) "make check-plist" followed by "make stage-qa" output  (https://www.freebsd.org/doc/en/books/porters-handbook/porting-testing.html)

and also provide the output of portlint -AC? Thanks!
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2014-09-06 05:28:42 UTC 
Additional QA results and updated needed.

Also:

 * Add LICENSE_FILE
Comment 3 tkato432 2014-09-06 19:12:03 UTC 
Created attachment 146963 [details]
games_tuxpaint-config.log
Comment 4 John Marino freebsd_committer freebsd_triage 2014-09-07 06:41:33 UTC 
FYI - this had no license at all, and LICENSE entry is no required.  It's not fair to ask for this if it's the only thing "wrong"
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2014-09-07 11:57:34 UTC 
Thank you John.
Comment 6 Marcus von Appen freebsd_committer freebsd_triage 2014-09-08 06:17:47 UTC 
I'm unsure about that change tkato:

+ MAN_PREFIX="${STAGEDIR}${MANPREFIX}/man" \
+ X11_ICON_PREFIX="${STAGEDIR}${PREFIX}/share/pixmaps/" \

Are they only used for the installation, but not referenced somewhere in the code? If they are used in the code or scripts and get substituted, the paths won't be resolved properly.

Since you are patching the paths in the Makefile with $(DESTDIR), I wonder if the change above is even necessary.
Comment 7 tkato432 2014-09-08 18:30:09 UTC 
Created attachment 147076 [details]
games_tuxpaint-config.diff

Refactored a bit.
Comment 8 Marcus von Appen freebsd_committer freebsd_triage 2014-09-09 05:17:31 UTC 
Thanks for the refactored version. The patch looks good, moving to patch ready.
Comment 9 commit-hook freebsd_committer freebsd_triage 2014-09-21 12:04:38 UTC 
A commit references this bug:

Author: pawel
Date: Sun Sep 21 12:03:46 UTC 2014
New revision: 368743
URL: http://svnweb.freebsd.org/changeset/ports/368743

Log:
  - Update to version 0.0.13
  - Add LICENSE

  PR:		ports/193324
  Submitted by:	tkato432@yahoo.com

Changes:
  head/games/tuxpaint-config/Makefile
  head/games/tuxpaint-config/distinfo
  head/games/tuxpaint-config/files/patch-Makefile
  head/games/tuxpaint-config/pkg-descr
  head/games/tuxpaint-config/pkg-plist