Bug 193821 - multimedia/libquvi: add LUAJIT option
Summary: multimedia/libquvi: add LUAJIT option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords: patch
Depends on:
Blocks: 193822
  Show dependency tree / graph
 
Reported: 2014-09-21 20:45 UTC by Jan Beich
Modified: 2015-01-07 14:54 UTC (History)
0 users

See Also:

Attachments
v1 (890 bytes, patch)
2014-09-21 20:45 UTC, Jan Beich 		no flags Details | Diff
|poudriere testport| log (9.3R i386) (23.57 KB, text/plain)
2014-09-21 20:50 UTC, Jan Beich 		no flags Details
|poudriere testport| log (10.0R amd64, LUAJIT=on) (24.06 KB, text/plain)
2014-09-21 20:51 UTC, Jan Beich 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2014-09-21 20:45:20 UTC 
Created attachment 147536 [details]
v1

Tested against multimedia/mpv. Leaving default as is. If you feel adventurous follow devel/love:

  # lang/luajit is BROKEN elsewhere
  OPTIONS_DEFAULT_i386=   LUAJIT
  OPTIONS_DEFAULT_amd64=  LUAJIT
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-09-21 20:45:20 UTC 
Auto-assigned to maintainer sunpoet@FreeBSD.org
Comment 2 Jan Beich freebsd_committer freebsd_triage 2014-09-21 20:50:21 UTC 
Created attachment 147537 [details]
|poudriere testport| log (9.3R i386)
Comment 3 Jan Beich freebsd_committer freebsd_triage 2014-09-21 20:51:31 UTC 
Created attachment 147538 [details]
|poudriere testport| log (10.0R amd64, LUAJIT=on)
Comment 4 Jan Beich freebsd_committer freebsd_triage 2014-09-21 21:14:49 UTC 
Before switching default value keep in mind consumers that also link against Lua e.g., multimedia/mpv. In such cases default should be in sync. However, according to FreshPorts only a few ports depend on libquvi by default and neither has USES=Lua.

Bug 193822 comment 4 has an example stacktrace after mixing Lua implementations.
Comment 5 Jan Beich freebsd_committer freebsd_triage 2014-09-21 23:52:32 UTC 
Here's a list of LIB_DEPENDS=libquvi.so consumers in ports tree. Only mpv has USES=lua in Makefile or from dependency. It should be safe to turn on LUAJIT by default together with bug 193822.

  multimedia/cclive
  multimedia/mpv
  multimedia/quvi
  multimedia/totem-pl-parser

multimedia/ffmpeg and multimedia/mplayer2 also support libquvi but not exposed in the ports. If exposed via option ffmpeg may cause a problem not by itself but by whatever depends on it e.g., multimedia/vlc. In such cases one may consider adding LUAJIT option there as well.
Comment 6 commit-hook freebsd_committer freebsd_triage 2014-10-01 20:07:36 UTC 
A commit references this bug:

Author: sunpoet
Date: Wed Oct  1 20:06:57 UTC 2014
New revision: 369750
URL: https://svnweb.freebsd.org/changeset/ports/369750

Log:
  - Add LUAJIT option

  PR:		ports/193821
  Submitted by:	Jan Beich <jbeich@vfemail.net>

Changes:
  head/multimedia/libquvi/Makefile
Comment 7 Po-Chuan Hsieh freebsd_committer freebsd_triage 2014-10-01 20:11:32 UTC 
Committed. Thanks!