Bug 193842 - Update net-p2p/btSync to 1.4.83
Summary: Update net-p2p/btSync to 1.4.83
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Jason E. Hale
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-22 18:48 UTC by joshruehlig
Modified: 2014-09-23 21:43 UTC (History)
1 user (show)

See Also:

Attachments
btsync 1.4.83 patch (1.26 KB, patch)
2014-09-22 18:48 UTC, joshruehlig 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description joshruehlig 2014-09-22 18:48:48 UTC 
Created attachment 147567 [details]
btsync 1.4.83 patch

The attached diff
* updates btsync to 1.4.83
Comment 1 commit-hook freebsd_committer freebsd_triage 2014-09-23 15:20:48 UTC 
A commit references this bug:

Author: jhale
Date: Tue Sep 23 15:20:28 UTC 2014
New revision: 369070
URL: http://svnweb.freebsd.org/changeset/ports/369070

Log:
  - Update to 1.4.83

  While here:
  - Clean up pkg-plist

  PR:		193842
  Submitted by:	<joshruehlig@gmail.com> (maintainer)

Changes:
  head/net-p2p/btsync/Makefile
  head/net-p2p/btsync/distinfo
  head/net-p2p/btsync/pkg-plist
Comment 2 joshruehlig 2014-09-23 15:44:30 UTC 
thanks, I'll see if I can understand the additional changes you added.

I also read pkgng may have a way to shutdown services upon deinstall, I'll want to add that too.
Comment 3 Jason E. Hale freebsd_committer freebsd_triage 2014-09-23 21:40:39 UTC 
(In reply to joshruehlig from comment #2)
> thanks, I'll see if I can understand the additional changes you added.

See CHANGES 20140922.  pkg now only needs @dir(user,group,mode) for special directories.  This effectively does the work of the @exec line (set the permissions) and the @unexec line (remove the directory).

> I also read pkgng may have a way to shutdown services upon deinstall, I'll
> want to add that too.

See the pkg.conf(5) manpage, specifically the HANDLE_RC_SCRIPTS option.  If set, it will automatically handle stop and start of services.  That is why I removed the first line of pkg-plist.  It was pretty much what @stopdaemon did, which was also removed a while back.
Comment 4 joshruehlig 2014-09-23 21:43:13 UTC 
awesome, I checked out changes and say the @dir option.
I'll read up on pkg, thanks.