Created attachment 147627 [details] shar file Simulation of Urban MObility (SUMO) is an open source, highly portable, microscopic and continuous road traffic simulation package designed to handle large road networks
- MASTER_SITES should use the SF macro: MASTER_SITES= SF/${PORTNAME}/${PORTNAME}/version%20${PORTVERSION} - I think cad would be a better category for this - Seems to be missing LIB_DEPENDS on graphics/gdal, graphics/proj, and textproc/xerces-c3 (instead of xerces-c2) - Everything below <bsd.port.options.mk> should be converted to options helpers - What exactly does the PYTHON option do? There doesn't seem to be any python files installed.
Created attachment 147707 [details] sumo shar >> - MASTER_SITES should use the SF macro: >> MASTER_SITES= SF/${PORTNAME}/${PORTNAME}/version%20${PORTVERSION} Done. >> - I think cad would be a better category for this Sure. >> - Seems to be missing LIB_DEPENDS on graphics/gdal, graphics/proj, and >> textproc/xerces-c3 (instead of xerces-c2) The gdal and proj are options but I don't really know what that does, so I didn't created the make options, should I? >> - Everything below <bsd.port.options.mk> should be converted to options helpers I don't really know what you mean, the options descriptions and options logic?! >> - What exactly does the PYTHON option do? There doesn't seem to be any python >> files installed. Sure, it doesn't install, but there are some python libraries in the work dir. I removed the option until I figure out how to install and test this python lib. P.S.: Sorry for my mistakes, I'm a bit new into porting =/
(In reply to Fynn from comment #2) > >> - Seems to be missing LIB_DEPENDS on graphics/gdal, graphics/proj, and > >> textproc/xerces-c3 (instead of xerces-c2) > The gdal and proj are options but I don't really know what that does, so I > didn't created the make options, should I? > It wouldn't configure for me without them, but I didn't look into whether they could be disabled. > >> - Everything below <bsd.port.options.mk> should be converted to options helpers > I don't really know what you mean, the options descriptions and options > logic?! > What I meant was .if ! ${PORT_OPTIONS:MGUI} CONFIGURE_ARGS+= --without-fox-config .endif Could just be: GUI_CONFIGURE_OFF= --without-fox-config Normally you could have used: GUI_CONFIGURE_WITH= fox-config but, in this case, --with-fox-config expects an argument. > >> - What exactly does the PYTHON option do? There doesn't seem to be any python >> files installed. > Sure, it doesn't install, but there are some python libraries in the work > dir. I removed the option until I figure out how to install and test this > python lib. > Alright. It could probably be installed with the post-install target. I just didn't know how useful the Python files were. I have no clue how this program works. It just seemed pointless to depend on Python if it didn't actually serve a purpose. > P.S.: Sorry for my mistakes, I'm a bit new into porting =/ No problem. We're here to help.
Created attachment 147857 [details] sumo shar Added LIB_DEPENDS on graphics/gdal and graphics/proj Better GUI configure
Created attachment 148302 [details] sumo.shar Fully working now.
Created attachment 188287 [details] Updated patch Updated the patch to version 0.31.0. Added the DOCS option. Added missing dependencies.
Committed with modifications. Thanks for your contribution!
A commit references this bug: Author: yuri Date: Sun Dec 3 19:20:36 UTC 2017 New revision: 455420 URL: https://svnweb.freebsd.org/changeset/ports/455420 Log: New port: cad/sumo: Traffic simulation suite for road vehicles, public transportation, etc PR: 193884 Submitted by: Enrique Fynn <me@enriquefynn.com> Approved by: tcberner (mentor) Differential Revision: https://reviews.freebsd.org/D13248 Changes: head/cad/Makefile head/cad/sumo/ head/cad/sumo/Makefile head/cad/sumo/distinfo head/cad/sumo/pkg-descr head/cad/sumo/pkg-plist