Bug 194083 - Upgrade audacity from 2.0.5 to 2.0.6
Summary: Upgrade audacity from 2.0.5 to 2.0.6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Many People
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-02 03:01 UTC by Jack
Modified: 2014-12-03 15:58 UTC (History)
3 users (show)

See Also:

Attachments
audacity upgrade patch (5.29 KB, text/plain)
2014-10-02 03:01 UTC, Jack 		no flags Details
New patch including a missing file (7.02 KB, patch)
2014-10-02 03:07 UTC, Jack 		no flags Details | Diff
new patch (9.71 KB, patch)
2014-10-30 00:07 UTC, Guido Falsi 		madpilot: maintainer-approval? (xxjack12xx)
 Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jack 2014-10-02 03:01:28 UTC 
Created attachment 147897 [details]
audacity upgrade patch

Upgrade audacity from 2.0.5 to 2.0.6
Use new ffmpeg libs
Comment 1 Jack 2014-10-02 03:07:27 UTC 
Created attachment 147898 [details]
New patch including a missing file

I forgot to add the 2nd patch, this new patch includes it.
Comment 2 Jack 2014-10-02 07:21:38 UTC 
Also need to remove files/patch-Makefile.in after applying the patch
Comment 3 Jack 2014-10-29 04:14:36 UTC 
Any update?
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2014-10-30 00:07:04 UTC 
Created attachment 148782 [details]
new patch

Hi,

Your submissio has a few problems. It was not working as is in any OS version.

I fixed various problems with it. Main things:

Removed some unneeded options

Patched various deficiencies in software build system, which were preventing build to succeed in various OS versions.

Removed RESAMPLE option which cannot work since files needed by it are missing from distribution

Please also note that your submission included the line:

/you/have/to/check/what/makeplist/gives/you

in the pkg-plist, it was the first line, which is a line generated on purpose by the "make makeplist" command.

This kind of mistake casts doubts on the quality of the checks you performed before submitting the patch.

Please test and review my patch and, if you see fit, approve it.

thanks.
Comment 5 Jack 2014-10-30 00:41:20 UTC 
Sorry about that, I will review and test.
Comment 6 Jack 2014-10-30 19:18:04 UTC 
I just tested the patch and it works fine, thanks for fixing my errors.
Comment 7 commit-hook freebsd_committer freebsd_triage 2014-10-30 21:10:56 UTC 
A commit references this bug:

Author: madpilot
Date: Thu Oct 30 21:10:52 UTC 2014
New revision: 371772
URL: https://svnweb.freebsd.org/changeset/ports/371772

Log:
  - Update to 2.0.6
  - Remove option not supported anymore
  - Use newer ffmpeg
  - Clean up uneeded directives

  PR:		194083
  Submitted by:	xxjack12xx at gmail.com (maintainer)

Changes:
  head/audio/audacity/Makefile
  head/audio/audacity/distinfo
  head/audio/audacity/files/patch-Makefile.in
  head/audio/audacity/files/patch-lib-src__libvamp__Makefile.in
  head/audio/audacity/files/patch-portaudio.h
  head/audio/audacity/files/patch-src__Makefile.in
  head/audio/audacity/pkg-plist
Comment 8 Guido Falsi freebsd_committer freebsd_triage 2014-10-30 21:11:17 UTC 
Committed, thanks!