Bug 194096 - [patch] net-mgmt/netxms switch to libc API instead of nosing in kernel memory via kvm(3)
Summary: [patch] net-mgmt/netxms switch to libc API instead of nosing in kernel memory...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Baptiste Daroussin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-02 16:03 UTC by Gleb Smirnoff
Modified: 2014-10-06 08:28 UTC (History)
1 user (show)

See Also:
bofh: maintainer-feedback? (bofh)

Attachments
the patch (10.20 KB, patch)
2014-10-02 16:03 UTC, Gleb Smirnoff 		no flags Details | Diff
patch for netxms-1.2.16 and switch to libc API instead of nosing in kernel memory via kvm(3) (19.90 KB, patch)
2014-10-06 05:50 UTC, Muhammad Moinur Rahman 		bofh: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gleb Smirnoff freebsd_committer freebsd_triage 2014-10-02 16:03:22 UTC 
Created attachment 147917 [details]
the patch

The patch fixes breakage of netxms on modern head, and prevents future
breakages, making it not depending on kernel ABI.

Note: I have only compile tested the patch, didn't perform any operation testing. I'd leave this to maintainer.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-10-02 16:03:22 UTC 
Maintainer CC'd
Comment 2 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2014-10-06 05:50:22 UTC 
Created attachment 148020 [details]
patch for netxms-1.2.16 and switch to libc API instead of nosing in kernel memory via kvm(3)

Poudriere logs:
http://pdr.s.ubze.ro/bulk/latest-per-pkg/netxms/1.2.16/

ports/193571 should be closed as I have merged both into one single patch. However I was trying to mark the other obsolete but I can't.
Comment 3 commit-hook freebsd_committer freebsd_triage 2014-10-06 08:27:29 UTC 
A commit references this bug:

Author: bapt
Date: Mon Oct  6 08:26:55 UTC 2014
New revision: 370146
URL: https://svnweb.freebsd.org/changeset/ports/370146

Log:
  Update to 1.2.16 [1]
  switch to libc API instead of nosing in kernel memory via kvm(3) [2]

  PR:		194096
  Submitted by:	glebius [1] maintainer [2]
  Approved by:	maintainer

Changes:
  head/net-mgmt/netxms/Makefile
  head/net-mgmt/netxms/distinfo
  head/net-mgmt/netxms/files/patch-src-agent-subagents-freebsd-freebsd.cpp
  head/net-mgmt/netxms/files/patch-src-agent-subagents-freebsd-net.cpp
  head/net-mgmt/netxms/files/patch-src-agent-subagents-freebsd-net.h
  head/net-mgmt/netxms/files/pkg-install.in
  head/net-mgmt/netxms/pkg-plist
Comment 4 Baptiste Daroussin freebsd_committer freebsd_triage 2014-10-06 08:28:20 UTC 
Committed thank you,

For the next version it will be great to unbundle libtre and libjansson, there is no need to use the internal version.