Bug 194190 - [MAINTAINER] devel/gdb thread fix and new signal trampoline sysctl adopted
Summary: [MAINTAINER] devel/gdb thread fix and new signal trampoline sysctl adopted
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Tijl Coosemans
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-06 16:09 UTC by luca.pizzamiglio
Modified: 2014-10-07 10:28 UTC (History)
1 user (show)

See Also:

Attachments
the patch to gdb 7.8_3 (4.37 KB, patch)
2014-10-06 16:09 UTC, luca.pizzamiglio 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description luca.pizzamiglio 2014-10-06 16:09:24 UTC 
Created attachment 148031 [details]
the patch to gdb 7.8_3

This patch solve an issue, using strcpy; now strncpy is used using moreover the right size (Thanks to James Muchow)

Adding the signal trampoline detection via the new sysctl. If the new sysctl is not available, gdb still uses the old sysctl.

Removing also some gcc specific warning options, causing tons of unuseful warnings.
Comment 1 commit-hook freebsd_committer freebsd_triage 2014-10-07 10:25:52 UTC 
A commit references this bug:

Author: tijl
Date: Tue Oct  7 10:25:44 UTC 2014
New revision: 370292
URL: https://svnweb.freebsd.org/changeset/ports/370292

Log:
  - Fix a buffer overflow when copying a string
  - Use sysctl KERN_PROC_SIGTRAMP to retrieve the signal trampoline
    location for the native amd64 ABI.  This fixes unwinding over the
    signal frame after trampoline was moved to the shared page.
    (https://svnweb.freebsd.org/changeset/base/258663)
  - Remove some gcc specific warning flags

  PR:		194190
  Submitted by:	luca.pizzamiglio@gmail.com (maintainer)

Changes:
  head/devel/gdb/Makefile
  head/devel/gdb/files/fbsd-threads.c
  head/devel/gdb/files/patch-gdb-amd64fbsd-nat.c
  head/devel/gdb/files/patch-gdb-configure