Bug 194222 - [maintainer-update] [patch] sysutils/vagrant to version 1.6.5
Summary: [maintainer-update] [patch] sysutils/vagrant to version 1.6.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Bartek Rutkowski
URL:
Keywords:
Depends on: 194221
Blocks:
  Show dependency tree / graph
 
Reported: 2014-10-07 15:18 UTC by joe
Modified: 2014-11-28 09:52 UTC (History)
2 users (show)

See Also:

Attachments
Poudriere Log (57.95 KB, text/x-log)
2014-10-07 15:18 UTC, joe 		no flags Details
Vagrant 1.6.5 update (2.72 KB, patch)
2014-10-07 15:20 UTC, joe 		no flags Details | Diff
Vagrant 1.6.5 update (49.01 KB, patch)
2014-10-08 23:42 UTC, joe 		no flags Details | Diff
Poudriere Log (28.16 KB, text/x-log)
2014-10-08 23:43 UTC, joe 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description joe 2014-10-07 15:18:53 UTC 
Created attachment 148065 [details]
Poudriere Log

sysutils/vagrant to version 1.6.5
Comment 1 joe 2014-10-07 15:20:54 UTC 
Created attachment 148066 [details]
Vagrant 1.6.5 update
Comment 2 John Marino freebsd_committer freebsd_triage 2014-10-08 18:48:32 UTC 
1) Great job on providing poudriere log!
2) Not so great on ignore errors in it:
===>  Building package for vagrant-1.6.5_1
pkg-static: Warning: @dirrm is deprecated please use @dir
pkg-static: Warning: @dirrm is deprecated please use @dir
pkg-static: Warning: @dirrm is deprecated please use @dir
pkg-static: Warning: @dirrm is deprecated please use @dir
pkg-static: Warning: @dirrm is deprecated please use @dir
pkg-static: Warning: @dirrm is deprecated please use @dir


Please remove all the @dirrm* lines in the pkg-plist, and check with poudriere again.
Comment 3 joe 2014-10-08 23:42:59 UTC 
Created attachment 148123 [details]
Vagrant 1.6.5 update
Comment 4 joe 2014-10-08 23:43:44 UTC 
Created attachment 148124 [details]
Poudriere Log
Comment 5 John Marino freebsd_committer freebsd_triage 2014-10-09 12:08:00 UTC 
Excellent!  moving to patch-ready pool.
Comment 6 Bartek Rutkowski freebsd_committer freebsd_triage 2014-10-11 10:35:33 UTC 
Hi,

You've added new line to RUN_DEPENDS:

rubygem-hashicorp-checkpoint>=0.1.4:${PORTSDIR}/www/rubygem-hashicorp-checkpoint \

And it seems like this port does not exist in the Ports Tree. Perhaps you have it locally and you should send a PR with that new port?
Comment 7 joe 2014-10-11 14:55:47 UTC 
This bug depends on another bug. That bug has the missing rubygem in question.
Comment 8 commit-hook freebsd_committer freebsd_triage 2014-10-14 09:30:05 UTC 
A commit references this bug:

Author: robak
Date: Tue Oct 14 09:29:41 UTC 2014
New revision: 370834
URL: https://svnweb.freebsd.org/changeset/ports/370834

Log:
  sysutils/vagrant: update 1.6.3 -> 1.6.5

  - Convert @dirrm to @dir

  PR:		194222
  Submitted by:	Joseph Benden <joe@thrallingpenguin.com>
  Approved by:	mentors (implicit)

Changes:
  head/sysutils/vagrant/Makefile
  head/sysutils/vagrant/distinfo
  head/sysutils/vagrant/pkg-plist
Comment 9 Bartek Rutkowski freebsd_committer freebsd_triage 2014-10-14 09:44:40 UTC 
Committed, thanks for your work!
Comment 10 John Marino freebsd_committer freebsd_triage 2014-11-28 09:52:25 UTC 
I just figured out that I must not have inspected the new patch.  This converted @dirrm to @dir, when the instructions were to *REMOVE* the lines, see:
  "Please remove all the @dirrm* lines in the pkg-plist, and check with poudriere again."

It's cleaned up now.

It's a lesson to both, I got sloppy on my review.