Bug 194270 - [new port] [request] databases/php56-redis version of php redis module
Summary: [new port] [request] databases/php56-redis version of php redis module
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Bartek Rutkowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-09 12:21 UTC by Daniel Ylitalo
Modified: 2014-11-16 14:46 UTC (History)
3 users (show)

See Also:

Attachments
shar (2.03 KB, patch)
2014-11-04 20:43 UTC, m.tsatsenko 		no flags Details | Diff
shar with fixed pkg prefix (2.03 KB, text/plain)
2014-11-13 14:08 UTC, Daniel Ylitalo 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Ylitalo 2014-10-09 12:21:00 UTC 
Hi!

There are identical copies of the redis module in
database/php53-redis
database/php5-redis
database/php55-redis

Now that php 5.6 is in the ports tree there should be yet another copy with default version 56
databases/php56-redis
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2014-10-17 20:37:13 UTC 
notify maintainer of php55-redis.
Comment 2 m.tsatsenko 2014-10-19 20:17:26 UTC 
Sounds reasonable for me.
Comment 3 John Marino freebsd_committer freebsd_triage 2014-11-01 10:09:39 UTC 
who is going to maintain it?
They should submit a shar file.
Comment 4 Daniel Gerzo freebsd_committer freebsd_triage 2014-11-03 19:57:09 UTC 
I guess m.tsatsenko@gmail.com should be nominated ;-)
Comment 5 m.tsatsenko 2014-11-04 20:40:45 UTC 
Agree
Comment 6 m.tsatsenko 2014-11-04 20:43:39 UTC 
Created attachment 149049 [details]
shar
Comment 7 John Marino freebsd_committer freebsd_triage 2014-11-04 20:46:43 UTC 
moving to patch-ready pool.
Comment 8 Baptiste Daroussin freebsd_committer freebsd_triage 2014-11-08 13:07:46 UTC 
The port should be named php5-redis not php56-redis
Comment 9 Daniel Gerzo freebsd_committer freebsd_triage 2014-11-08 13:30:59 UTC 
Baptiste, I tried to use DEFAULT_VERSIONS=php=5.6 with php5-redis as you suggested on IRC, but it doesn't seem to work as it should. When I run poudriere it still tries to build php5 and also php5-session, even thoguh I want 5.6 only. So, either the current php5-redis port does not seem to honor this setting, or we still need php56-redis like with some other php modules...well I am no expert here I'm just saying it doesn't work.
Comment 10 Baptiste Daroussin freebsd_committer freebsd_triage 2014-11-12 13:47:39 UTC 
right ok I was wrong and showed how much I lack knownledge on the php framework :)
Comment 11 Daniel Ylitalo 2014-11-13 12:11:02 UTC 
The shar has a minor typo, pkg prefix is set to php5 and not php56 which it should be (i believe?)
Comment 12 John Marino freebsd_committer freebsd_triage 2014-11-13 13:11:00 UTC 
you submitted it, so you can update it if you think it's wrong!
Comment 13 Daniel Ylitalo 2014-11-13 14:07:50 UTC 
Actually it wasn't me who submitted it, but here is a new one anyhow :)
Comment 14 Daniel Ylitalo 2014-11-13 14:08:28 UTC 
Created attachment 149379 [details]
shar with fixed pkg prefix
Comment 15 commit-hook freebsd_committer freebsd_triage 2014-11-16 14:36:48 UTC 
A commit references this bug:

Author: robak
Date: Sun Nov 16 14:36:01 UTC 2014
New revision: 372639
URL: https://svnweb.freebsd.org/changeset/ports/372639

Log:
  databases/php56-redis: NEW PORT - PHP5 extension for Redis

  This extension provides an API for communicating with Redis database,
  a persistent key-value database with built-in net interface written
  in ANSI-C for Posix systems.

  It is a fork of alfonsojimenez's phpredis, adding many methods and
  fixing a lot of issues.

  WWW: https://github.com/nicolasff/phpredis

  PR:		194270
  Submitted by:	Daniel Ylitalo <daniel at blodan.se>
  Approved by:	mentors (implicit)

Changes:
  head/databases/Makefile
  head/databases/php56-redis/
  head/databases/php56-redis/Makefile
  head/databases/php56-redis/distinfo
  head/databases/php56-redis/pkg-descr
Comment 16 Bartek Rutkowski freebsd_committer freebsd_triage 2014-11-16 14:38:11 UTC 
Committed, thanks for you work guys!
Comment 17 Daniel Ylitalo 2014-11-16 14:39:33 UTC 
Hi Robak,

You comitted the wrong shar unfortunately :\

PKGNAMEPREFIX needs to be php56-
Comment 18 commit-hook freebsd_committer freebsd_triage 2014-11-16 14:45:50 UTC 
A commit references this bug:

Author: robak
Date: Sun Nov 16 14:45:30 UTC 2014
New revision: 372640
URL: https://svnweb.freebsd.org/changeset/ports/372640

Log:
  databases/php56-redis: fix PKGNAMEPREFIX

  PR:		194270
  Submitted by:	Daniel Ylitalo <daniel at blodan.se>
  Approved by:	mentors(implicit)

Changes:
  head/databases/php56-redis/Makefile
Comment 19 Bartek Rutkowski freebsd_committer freebsd_triage 2014-11-16 14:46:18 UTC 
Daniel, thanks for pointing that out, sorry for that mistake.