Bug 194300 - [new port] security/esteidfirefoxplugin - digital signing in Firefox with Estonian ID-card
Summary: [new port] security/esteidfirefoxplugin - digital signing in Firefox with Est...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Tijl Coosemans
URL:
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2014-10-11 14:19 UTC by toomas.aas
Modified: 2015-10-09 09:21 UTC (History)
0 users

See Also:

Attachments
The port (3.24 KB, text/plain)
2014-10-11 14:19 UTC, toomas.aas 		no flags Details
Updated port (3.27 KB, text/plain)
2014-12-23 17:40 UTC, toomas.aas 		no flags Details
poudriere test log (31.41 KB, text/x-log)
2015-01-16 17:47 UTC, toomas.aas 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description toomas.aas 2014-10-11 14:19:57 UTC 
Created attachment 148191 [details]
The port

This plugin enables in-browser digital signing in Firefox with Estonian ID-card
Comment 1 John Marino freebsd_committer freebsd_triage 2014-10-31 19:30:23 UTC 
Is there any chance you could provide a poudriere test log with stage-qa checks performed?

And is there a reason you used pre-install instead of post-install target?
Comment 2 toomas.aas 2014-11-02 21:27:43 UTC 
There is no particular reason why I used pre-install instead of post-install. I tested after replacing pre-install with post-install, it works.

Poudriere will take some time as I don't have it set up yet.
Comment 3 Jan Beich freebsd_committer freebsd_triage 2014-12-13 04:16:12 UTC 
Comment on attachment 148191 [details]
The port

Defining USE_OPENSSL=yes and removing ${WRKSRC}/include/openssl maybe better over using bundled headers from OpenSSL 1.0.0b 16 Nov 2010.

>X I_FLAGS = -Iinclude -Icommon `pkg-config --cflags gtk+-2.0`
>X-L_FLAGS = -ldl -lcrypto -lpthread `pkg-config --libs gtk+-2.0`
>X+L_FLAGS = -lcrypto -lpthread `pkg-config --libs gtk+-2.0`

Don't you also need USES=pkgconfig ?
Comment 4 toomas.aas 2014-12-23 17:40:17 UTC 
Created attachment 150915 [details]
Updated port

Makefile updated according to suggestions made by Jan Beich.
Comment 5 toomas.aas 2015-01-16 17:47:00 UTC 
Created attachment 151743 [details]
poudriere test log
Comment 6 John Marino freebsd_committer freebsd_triage 2015-05-17 16:00:19 UTC 
I'll promote this.
Comment 7 commit-hook freebsd_committer freebsd_triage 2015-10-09 09:07:03 UTC 
A commit references this bug:

Author: tijl
Date: Fri Oct  9 09:06:17 UTC 2015
New revision: 398906
URL: https://svnweb.freebsd.org/changeset/ports/398906

Log:
  New port: security/esteidfirefoxplugin

  A Firefox plugin that enables in-browser digital signing with Estonian ID
  cards.

  PR:		194300
  Submitted by:	toomas.aas@raad.tartu.ee
  Reviewed by:	marino

Changes:
  head/security/Makefile
  head/security/esteidfirefoxplugin/
  head/security/esteidfirefoxplugin/Makefile
  head/security/esteidfirefoxplugin/distinfo
  head/security/esteidfirefoxplugin/files/
  head/security/esteidfirefoxplugin/files/patch-Makefile
  head/security/esteidfirefoxplugin/pkg-descr