Bug 194380 - [PATCH] www/sams2: fix pkg-plist and compatibility with percona and mariadb
Summary: [PATCH] www/sams2: fix pkg-plist and compatibility with percona and mariadb
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Many People
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-15 13:47 UTC by Ralf van der Enden
Modified: 2014-11-02 18:30 UTC (History)
1 user (show)

See Also:

Attachments
sams2-2.0.0.patch (2.45 KB, patch)
2014-10-15 13:47 UTC, Ralf van der Enden 		no flags Details | Diff
Poudriere build log (amd64) (70.16 KB, text/plain)
2014-10-15 13:50 UTC, Ralf van der Enden 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf van der Enden 2014-10-15 13:47:26 UTC 
Created attachment 148337 [details]
sams2-2.0.0.patch

- Fix pkg-plist (add 2 missing entries and change @dirrm to @dir)
- Change the RUN_DEPENDS for mysql-server so it's compatible with perconadb and mariadb

Port maintainer (roma.a.g@gmail.com) is cc'd.

Generated with FreeBSD Port Tools 1.02 (mode: change, diff: GIT)
Comment 1 Ralf van der Enden 2014-10-15 13:50:14 UTC 
Created attachment 148338 [details]
Poudriere build log (amd64)
Comment 2 John Marino freebsd_committer freebsd_triage 2014-10-16 08:15:02 UTC 
I don't know why maintainer wasn't automatically CC'd, but I'm doing it now.
Comment 3 Roman 2014-10-16 09:13:25 UTC 
Hi John, got message yesterday.
Approval needed from me? How to do it?
Comment 4 Ralf van der Enden 2014-10-22 14:36:11 UTC 
As far as I know you just add a comment saying you approve the patch. At least that's what I do for the ports I maintain.
Comment 5 Roman 2014-10-22 15:07:23 UTC 
Approved.
Comment 6 John Marino freebsd_committer freebsd_triage 2014-11-01 15:34:35 UTC 
Ralf, the pkg-plist changes are incorrect.
@dir is not an alias for @dirrm or @dirrmtry
In 99% of the cases, old @dirrm* lines are simply removed.
see /usr/ports/CHANGES for the proper way to use @dir

If you submit an updated patch that addresses the plist issue, I'll move it patch-ready pool
Comment 7 commit-hook freebsd_committer freebsd_triage 2014-11-02 18:28:51 UTC 
A commit references this bug:

Author: marino
Date: Sun Nov  2 18:28:35 UTC 2014
New revision: 372083
URL: https://svnweb.freebsd.org/changeset/ports/372083

Log:
  www/sams2: fix compatibility with percona and mariadb

  PR:		194380
  Submitted by:	Ralf van der Enden
  Approved by:	maintainer

Changes:
  head/www/sams2/Makefile
  head/www/sams2/pkg-plist
Comment 8 John Marino freebsd_committer freebsd_triage 2014-11-02 18:30:16 UTC 
I just fixed this myself to get it off my plate.

I also bumped the portrevision.

Thanks!