Created attachment 148416 [details] Poco 1.5.4 update. devel/poco-devel version 1.5.4. Note: There are 2 new patch files.
Created attachment 148417 [details] Poudriere Log GZip Poudriere log.
The Poudriere log may be viewed with zcat.
the poudriere log is a single file? Or did you gzip the entire poudriere bulk run directory?
I gzip'd the log file, not the directory. The file is larger than the maximum post size.
you're right, 7MB log file. The stage-qa check shows a bunch of libraries that need stripping. Did you see that? Two bin programs too. In the worst case you can strip those with a post-install target.
Those unstripped files are for debug purposes. So they need to stay unstripped. Same with the test binaries.
er, no. They are only left unstripped if WITH_DEBUG is set. Otherwise they are stripped. Just like the other 24,000 ports. ${STRIP_CMD} morphs based on setting of WITH_DEBUG.
The other way to think about this: The port getting warnings on the sanity check implemented by portmgr, so it's checking the policies that portmgr wants. If you need further confirmation that the ports should pass all the stage-qa tests, including the stripped test, you can ask on #bsdports irc channel. A mini-test is doing this in the port's directory: > make -V STRIP_CMD then > make WITH_DEBUG=yes -V STRIP_CMD and see how it changes the value.
Created attachment 149226 [details] Poudriere Log (Gziped)
Created attachment 149227 [details] Poco 1.5.4 update.
okay, this: + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libPocoUtild.so.24 + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libPocoPDFd.so.24 + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libPocoNetd.so.24 + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libPocoNetSSLd.so.24 + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libPocoJSONd.so.24 + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libPocoDataSQLited.so.24 + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libPocoXMLd.so.24 + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libPocoCppParserd.so.24 + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libPocoFoundationd.so.24 + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libPocoDataODBCd.so.24 + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libPocoMongoDBd.so.24 + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libPocoCryptod.so.24 + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libPocoDataMySQLd.so.24 + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libPocoDatad.so.24 + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libPocoZipd.so.24 should be replace with + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/*.so this: +@dir include/Poco/DOM +@dir include/Poco/SAX +@dir include/Poco/XML +@dir include/Poco/Util +@dir include/Poco/Net +@dir include/Poco/Zip +@dir include/Poco/PDF +@dir include/Poco/MongoDB +@dir include/Poco/JSON +@dir include/Poco/Dynamic +@dir include/Poco/Data/SQLite +@dir include/Poco/Data/ODBC +@dir include/Poco/Data/MySQL +@dir include/Poco/Data +@dir include/Poco/Crypto +@dir include/Poco/CppParser +@dir include/Poco should be *** COMPLETELY *** removed @dir is not a new alias for @dirrm or @dirrmtry, it has a specific purpose (see /usr/ports/CHANGES to learn about how it's supposed to be used)
FYI, makeplist was dumping a bunch of @dir lines that weren't necessary but that's been fixed now. Still, don't trust "make makeplist" at all, you have to check every line.
Created attachment 149259 [details] Poco 1.5.4 update.
Okay. I suspect with a glob we could reduce the number of strip commands from 4 to 2 in the post-install target but I know we are both tired of this PR and it works as it is, so I'm promoting the PR now.
Hi, The patch you've supplied seems to have few issues: * pkg-plist fails to apply * the size in distinfo is different from the one that gets downloaded * the patch-Data-MySQL-testsuite-Makefile fails to apply Please, update your ports tree to latest version and fix the above issues, so I could test your submission with new patch. Kind regards, Bartek Rutkowski
Joe, any news on that?
The patch applies cleanly for myself. The file patch-Data-MySQL-testsuite-Makefile does not exist.
Joe, my ports tree for poco-devel is on revision 373520 and unfortunately, your patch isnt applying properly for me. Unless you can get your sources updated to this revision and provide a working patch, I wont be able to commit that port, I am afraid.
I successfully applied the patch against Git revision: commit 455793d73333ba3fb4dadf46fd7ca13dab001f15 Author: delphij <delphij@FreeBSD.org> Date: Tue Dec 2 18:53:38 2014 +0000 Add CPE data. Requested by: des At this point, I'm not sure what to do - are you using patch -p1 < <patch>? Any input is appreciated. Thanks, -Joe
Joe, The last log entry from the SVN version (which is official source of ports tree) looks like that: ------------------------------------------------------------------------ r371551 | bapt | 2014-10-27 12:03:00 +0100 (Mon, 27 Oct 2014) | 2 lines Cleanup plist Can you please check out the SVN version of ports tree and test applying your patch against that version? Kind regards, Bartek Rutkowski
Created attachment 150471 [details] Poco 1.5.4 update. Please give this patch a go. It seems to work for me on SVN checkout.
Hi, Thanks for new patch, it applies just fine now, however, when testing it fails on incorrect distinfo data, as you can see in the log: http://pd.valinor.palantiri.org/data/11amd64-default/2014-12-11_17h14m29s/logs/errors/poco-devel-1.5.4.log Kind regards, Bartek Rutkowski
Created attachment 150482 [details] Poco 1.5.4 update. Please give this a go. I am currently trying it under Poudriere. The upstream package changed SHAs, so I had to update two things.
A commit references this bug: Author: robak Date: Wed Dec 17 11:23:17 UTC 2014 New revision: 374839 URL: https://svnweb.freebsd.org/changeset/ports/374839 Log: devel/poco-devel: update 1.5.3 -> 1.5.4 PR: 194441 Submitted by: Joseph Benden <joe@thrallingpenguin.com> Changes: head/devel/poco-devel/Makefile head/devel/poco-devel/distinfo head/devel/poco-devel/files/patch-Foundation-Makefile head/devel/poco-devel/files/patch-pcre head/devel/poco-devel/files/patch-pcre_internal.h head/devel/poco-devel/pkg-plist
Committed, thanks for your work!