Bug 194497 - math/ump: Fix build on -current
Summary: math/ump: Fix build on -current
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-20 18:03 UTC by tkato432
Modified: 2015-02-06 18:26 UTC (History)
1 user (show)

See Also:

Attachments
math_ump.diff (3.78 KB, patch)
2014-10-20 18:03 UTC, tkato432 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description tkato432 2014-10-20 18:03:05 UTC 
Created attachment 148512 [details]
math_ump.diff
Comment 1 John Marino freebsd_committer freebsd_triage 2014-10-23 15:51:12 UTC 
hmm, I have same question about lines 32-34 on this PR.  Why was this changed?

A) it doesn't do anything different
B) it arguably changes the style from "desireable" to "less desirable"

In other words, avoiding a compound command joined with "&&" and isolated with parenthesis is desired when possible (assuming it doesn't make the line really long).  So the change seems unnecessary and not really wanted.
Comment 2 John Marino freebsd_committer freebsd_triage 2014-10-31 14:31:21 UTC 
ping
Comment 3 John Marino freebsd_committer freebsd_triage 2015-02-06 17:59:06 UTC 
I'm tired of looking at this.  Let's see if I can work with it.
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-02-06 18:25:57 UTC 
A commit references this bug:

Author: marino
Date: Fri Feb  6 18:25:06 UTC 2015
New revision: 378549
URL: https://svnweb.freebsd.org/changeset/ports/378549

Log:
  math/ump: Finish original "fix on current"

  Back on 10 OCT 2014 when the PR was opened, this unmaintained port
  didn't build on current.  The PR stagnanted due to an unanswered
  question and the port was eventually fixed by amdmi3 on 21 NOV.  Let's
  go ahead and make the remaining changes which include adding a license
  (GPLv2), defining desktop entries, tweaking pkg-descr, and make real_frac
  function match its changed header (for clang).

  PR:		194497
  Submitted by:	Ports Fury

Changes:
  head/math/ump/Makefile
  head/math/ump/files/patch-Makefile
  head/math/ump/files/patch-src__real.cpp
  head/math/ump/pkg-descr