Bug 194553 - [NEW PORT] databases/pecl-yac: Yac is a shared and lockless memory user data cache for PHP.
Summary: [NEW PORT] databases/pecl-yac: Yac is a shared and lockless memory user data ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-23 13:47 UTC by johnpupu
Modified: 2014-11-05 01:34 UTC (History)
1 user (show)

See Also:


Attachments
pecl-yac shar file (2.58 KB, text/plain)
2014-10-23 14:17 UTC, johnpupu
no flags Details
upload updated shar (2.40 KB, text/plain)
2014-11-01 15:58 UTC, johnpupu
no flags Details
Upload test logs (32.27 KB, text/plain)
2014-11-01 15:59 UTC, johnpupu
no flags Details
Upload test logs (32.16 KB, text/plain)
2014-11-01 16:33 UTC, johnpupu
no flags Details
upload updated shar (2.45 KB, text/plain)
2014-11-01 16:35 UTC, johnpupu
no flags Details
upload updated shar (32.16 KB, text/plain)
2014-11-01 16:52 UTC, johnpupu
no flags Details
upload updated shar (2.68 KB, text/plain)
2014-11-01 16:55 UTC, johnpupu
no flags Details
Upload test logs (32.16 KB, text/plain)
2014-11-01 16:56 UTC, johnpupu
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description johnpupu 2014-10-23 13:47:13 UTC
[description of the port]

WWW: http://port.home.page/

Generated with FreeBSD Port Tools 1.02 (mode: new)

Fix:
--- pecl-yac-0.9.2.shar ends here ---
Comment 1 johnpupu 2014-10-23 14:17:52 UTC
Created attachment 148580 [details]
pecl-yac shar file
Comment 2 John Marino freebsd_committer freebsd_triage 2014-11-01 13:04:56 UTC
some minor issues:

XEXTRACT_SUFX=  .tgz

that should be USES=tar:tgz

XPHP_MODNAME=   ${PORTNAME:tl}

Unless there is a good reason to use PORTNAME, I'd rather this be hardcoded.


For new ports we also like to see test logs (poudriere wth stage-qa checks) or at least make-checkplist, make stage-qa, and portlint output.
Comment 3 johnpupu 2014-11-01 15:58:28 UTC
Created attachment 148883 [details]
upload updated shar

1.
Change EXTRACT_SUFX=  .tgz
to 
USES=tar:tgz
2.
remove PHP_MODNAME=   ${PORTNAME:tl}
Comment 4 johnpupu 2014-11-01 15:59:46 UTC
Created attachment 148884 [details]
Upload test logs

poudriere wth stage-qa checks
Comment 5 John Marino freebsd_committer freebsd_triage 2014-11-01 16:07:00 UTC
hmm, it looks like INSTALL_TARGET= install-strip didn't work.

see in log?

Warning: 'lib/php/20100525/yac.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}

That means you probably need to remove it and instead use something like:
post-install:
   @${STRIP_COMMAND} ${STAGEDIR}${ ??? }/yac.so

I'm sure there's a variable for lib/php/20100525, "make -V PLIST_SUB" will probably reveal it.

A little nit, but is USES=tar:tgz tabbed once or twice?  It should be twice to line up with the rest of the lines.
Comment 6 johnpupu 2014-11-01 16:33:00 UTC
Created attachment 148885 [details]
Upload test logs

poudriere wth stage-qa checks
Comment 7 johnpupu 2014-11-01 16:35:33 UTC
Created attachment 148886 [details]
upload updated shar

1.
Fix Warning: 'lib/php/20100525/yac.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}

2.
Change lib/php/20100525 to lib/php/${PHP_EXT_DIR}

3.
tab twice USES=tar:tgz
Comment 8 John Marino freebsd_committer freebsd_triage 2014-11-01 16:43:36 UTC
Hmmm, it's strange that the auto-plist still inserts @dirrm but that is not this ports fault.


I'll promote this as it is because you've been so patient. :)
However, I'll make the recommendation for the next committer that this line:

XCOMMENT=	Yac is a shared and lockless memory user data cache for PHP.

gets changed to

XCOMMENT=	Shared and lockless memory user data cache for PHP.


It is against style rules to use the name of the port in the short description of the port.  If you want to upload a final update after I promote it to fix that, it would be great.

Thanks!
Comment 9 johnpupu 2014-11-01 16:52:37 UTC
Created attachment 148889 [details]
upload updated shar
Comment 10 johnpupu 2014-11-01 16:55:42 UTC
Created attachment 148890 [details]
upload updated shar

Hi John,
Thanks for your help too.

New shar file change
1.
XCOMMENT=	Yac is a shared and lockless memory user data cache for PHP.
gets changed to
XCOMMENT=	Shared and lockless memory user data cache for PHP.
Comment 11 johnpupu 2014-11-01 16:56:56 UTC
Created attachment 148891 [details]
Upload test logs
Comment 12 commit-hook freebsd_committer freebsd_triage 2014-11-04 19:10:01 UTC
A commit references this bug:

Author: marino
Date: Tue Nov  4 19:09:49 UTC 2014
New revision: 372163
URL: https://svnweb.freebsd.org/changeset/ports/372163

Log:
  Add new port databases/pecl-yac

  PR:		194553
  Submitted by:	John Pupu

  Yac is a shared memory user data cache for PHP.  It can be used instead of
  APC or local memcached.

  Yac is lockless, which it is very fast, but there could be a chance the
  wrong data will be retrieved (it depends on how many key slots are
  allocated and how many keys are stored), so a product using Yac should not
  be very sensitive to data loss.

Changes:
  head/databases/Makefile
  head/databases/pecl-yac/
  head/databases/pecl-yac/Makefile
  head/databases/pecl-yac/distinfo
  head/databases/pecl-yac/files/
  head/databases/pecl-yac/files/pkg-message.in
  head/databases/pecl-yac/pkg-descr
Comment 13 John Marino freebsd_committer freebsd_triage 2014-11-04 19:12:57 UTC
I made some minor changes.

PKGMESSAGE was redefined unnecessarily, so I removed that.
I made pkg-message.in more concise and removed the wrapping at 80 columns
The English was pretty brutal so I attempted to make it better, but I can see that messed up on the "it is very fast" clause.

Anyway, it's in ports now, thanks!
Comment 14 Antoine Brodin freebsd_committer freebsd_triage 2014-11-04 21:59:52 UTC
I remove this port as it is duplicate of devel/pecl-yac
Please submit an update if you want.
Comment 15 John Marino freebsd_committer freebsd_triage 2014-11-04 22:02:43 UTC
well this is embarrassing.

The port got removed.

why?

Because it already exists.


MOVED
+databases/pecl-yac|devel/pecl-yac|2014-11-04|Duplicate port
Comment 16 John Marino freebsd_committer freebsd_triage 2014-11-04 22:03:23 UTC
well, as antoine just said.
Comment 17 johnpupu 2014-11-05 01:34:01 UTC
oops...

It's my stupid mistake ..

I will send another pr for update

Thanks John for help