Bug 194575 - irc/weechat: Request to remove "CFLAGS+= -Qunused-arguments" line
Summary: irc/weechat: Request to remove "CFLAGS+= -Qunused-arguments" line
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jase Thew
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-24 11:47 UTC by John Marino
Modified: 2014-10-27 12:25 UTC (History)
0 users

See Also:
marino: maintainer-feedback? (jase)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Marino freebsd_committer freebsd_triage 2014-10-24 11:47:18 UTC 
The latest update to irc/weechat breaks if gcc4.7+ is used.  modern gcc emits errors when unrecognized command line switches are given (older gcc just silently ignores them).

This change broke the build on dports, and it will break on ports if "USE_GCC=yes" is set.

To confirm, add "USE_GCC=yes" to makefile and watch it fail to configure.


I have commit access, so I can remove the line myself if you approve.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-10-24 11:47:18 UTC 
Auto-assigned to maintainer jase@FreeBSD.org
Comment 2 Jase Thew freebsd_committer freebsd_triage 2014-10-27 09:42:44 UTC 
(In reply to John Marino from comment #0)
> The latest update to irc/weechat breaks if gcc4.7+ is used.  modern gcc
> emits errors when unrecognized command line switches are given (older gcc
> just silently ignores them).
> 
> This change broke the build on dports, and it will break on ports if
> "USE_GCC=yes" is set.
> 
> To confirm, add "USE_GCC=yes" to makefile and watch it fail to configure.
> 
> 
> I have commit access, so I can remove the line myself if you approve.

Sure, go ahead.
Comment 3 commit-hook freebsd_committer freebsd_triage 2014-10-27 12:23:32 UTC 
A commit references this bug:

Author: marino
Date: Mon Oct 27 12:23:16 UTC 2014
New revision: 371561
URL: https://svnweb.freebsd.org/changeset/ports/371561

Log:
  irc/weechat: Remove CFLAGS+= Qunused-arguments

  That switch is not recognized by GCC, and GCC 4.7 and later will
  considered unrecognized switches as errors and break the build.  This
  was seen on dports, but can be reproduced on ports with USE_GCC=yes.

  PR:		194575
  Approved by:	jase@ (maintainer)

Changes:
  head/irc/weechat/Makefile
Comment 4 John Marino freebsd_committer freebsd_triage 2014-10-27 12:25:16 UTC 
Done, thanks!