Bug 194629 - mail/dovecot2 startup script breaks rcvar command
Summary: mail/dovecot2 startup script breaks rcvar command
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Adam Weinberger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-27 12:43 UTC by reinier
Modified: 2014-10-27 15:47 UTC (History)
0 users

See Also:
reinier: maintainer-feedback? (adamw)

Attachments
Patch to fix it (815 bytes, patch)
2014-10-27 12:43 UTC, reinier 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description reinier 2014-10-27 12:43:54 UTC 
Created attachment 148702 [details]
Patch to fix it

In the current version (2.2.15) of mail/dovecot2 the startup script /usr/local/etc/rc.d/dovecot only runs the rcvar command when dovecot_enable="YES" is set to the appropriate configuration file.

This breaks for instance the puppet provider which issues rcvar to gather information how to enable dovecot in the first place and leaves me with a chicken-egg problem.

The exact same bug was issued (#177497) for mail/dovecot and fixed after 1 and a half year, let's not hope it will takes as long for this port.

I've attached a similar patch how to fix this. This basically removes the checkyesno check, but this is handled with the run_rc_command anyway.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-10-27 12:43:54 UTC 
Auto-assigned to maintainer adamw@FreeBSD.org
Comment 2 commit-hook freebsd_committer freebsd_triage 2014-10-27 15:45:50 UTC 
A commit references this bug:

Author: adamw
Date: Mon Oct 27 15:45:20 UTC 2014
New revision: 371588
URL: https://svnweb.freebsd.org/changeset/ports/371588

Log:
  Remove the checkyesno dovecot_enable section, as it prevents onestart/onestop
  from working (as well as other things).

  I suspect this behaviour is present in other rc-files... a general cleanup on
  this might be in order.

  PR:		194629
  Submitted by:	Reinier Schoof

Changes:
  head/mail/dovecot2/Makefile
  head/mail/dovecot2/files/dovecot.in
Comment 3 Adam Weinberger freebsd_committer freebsd_triage 2014-10-27 15:47:32 UTC 
You are completely right on this, Reinier. Thank you!