Bug 194687 - [patch] multimedia/mplayer fails to build on armv6
Summary: [patch] multimedia/mplayer fails to build on armv6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Many People
Assignee: Thomas Zander
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-29 15:59 UTC by Mikael Urankar
Modified: 2014-11-01 16:14 UTC (History)
1 user (show)

See Also:
mikael: maintainer-feedback? (riggs)

Attachments
patch-configure (1.99 KB, patch)
2014-10-29 15:59 UTC, Mikael Urankar 		no flags Details | Diff
Replacement for files/patch-configure (5.64 KB, patch)
2014-10-30 21:01 UTC, Mikael Urankar 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer freebsd_triage 2014-10-29 15:59:51 UTC 
Created attachment 148768 [details]
patch-configure

mplayer currently fails to build on armv6 with this error:
libavcodec/arm/h264dsp_init_arm.c:110:9: error: use of undeclared identifier 'HAVE_SETEND'

This error was fixed in mplayer by SVN r37258, the commit log is at [1] and the diff (my patch is based on that) can be obtained with:
svn diff -r 37257:37258 svn://svn.mplayerhq.hu/mplayer/trunk

My redports account is not activated yet so I can't provide build logs on amd64/i386 arch but it builds fine on amd64/current.

[1] http://comments.gmane.org/gmane.comp.video.mplayer.cvs/21798
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-10-29 15:59:51 UTC 
Auto-assigned to maintainer riggs@FreeBSD.org
Comment 2 Mikael Urankar freebsd_committer freebsd_triage 2014-10-30 11:11:24 UTC 
build log on armv6:
http://mikael.urankar.free.fr/FreeBSD/arm/build_logs/mplayer/build.log
Comment 3 Sean Bruno freebsd_committer freebsd_triage 2014-10-30 19:44:31 UTC 
It looks like the port already has a patch-configure in it.  Are you replacing the existing file or updating it with yours?
Comment 4 Mikael Urankar freebsd_committer freebsd_triage 2014-10-30 21:01:38 UTC 
Created attachment 148802 [details]
Replacement for files/patch-configure
Comment 5 Mikael Urankar freebsd_committer freebsd_triage 2014-10-30 21:06:55 UTC 
It was an update of the existing file, I've attached a full patch.
Comment 6 Sean Bruno freebsd_committer freebsd_triage 2014-10-31 03:14:59 UTC 
This looks good for ARM, I'll schedule a redports build next.

http://crack.ysv.freebsd.org/data/11-armv6-test-ports_armv6/2014-10-31_00h10m11s/logs/mplayer-1.1.r20140824_3.log
Comment 7 Thomas Zander freebsd_committer freebsd_triage 2014-10-31 06:05:16 UTC 
Thanks for catching this one guys. I'll double check on the weekend!
Comment 8 commit-hook freebsd_committer freebsd_triage 2014-11-01 11:09:10 UTC 
A commit references this bug:

Author: riggs
Date: Sat Nov  1 11:09:01 UTC 2014
New revision: 372003
URL: https://svnweb.freebsd.org/changeset/ports/372003

Log:
  Fix build on armv6
  - Merge patch to configure script from upstream r37258

  PR:		194687
  Submitted by:	mikael.urankar@gmail.com
  Reviewed by:	riggs
  MFH:		2014Q4

Changes:
  head/multimedia/mplayer/files/patch-configure
Comment 9 commit-hook freebsd_committer freebsd_triage 2014-11-01 16:14:37 UTC 
A commit references this bug:

Author: riggs
Date: Sat Nov  1 16:13:49 UTC 2014
New revision: 372018
URL: https://svnweb.freebsd.org/changeset/ports/372018

Log:
  MFH: r372003

  Fix build on armv6
  - Merge patch to configure script from upstream r37258

  PR:		194687
  Submitted by:	mikael.urankar@gmail.com
  Reviewed by:	riggs
  Approved by:	portmgr (rea)

Changes:
_U  branches/2014Q4/
  branches/2014Q4/multimedia/mplayer/files/patch-configure