Bug 194767 - [PATCH] sysutils/mcelog contains a patch adding code for an obsolete FreeBSD version
Summary: [PATCH] sysutils/mcelog contains a patch adding code for an obsolete FreeBSD ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-02 19:07 UTC by ftigeot
Modified: 2014-11-03 08:54 UTC (History)
3 users (show)

See Also:
jdc: maintainer-feedback+

Attachments
New version of sysutils/mcelog/files/patch-config.c (557 bytes, patch)
2014-11-02 19:07 UTC, ftigeot 		no flags Details | Diff
Patch relative to the port directory (1.06 KB, patch)
2014-11-02 19:40 UTC, ftigeot 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ftigeot 2014-11-02 19:07:34 UTC 
Created attachment 148951 [details]
New version of sysutils/mcelog/files/patch-config.c

sysutils/mcelog contains a patch adding specific code for FreeBSD 8.0, files/patch-config.c

I have attached a new version of this file removing the problematic code.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-11-02 19:07:34 UTC 
Maintainer CC'd
Comment 2 ftigeot 2014-11-02 19:40:05 UTC 
Created attachment 148957 [details]
Patch relative to the port directory

The same change, as a diff relative to the existing version of the port.
Comment 3 Jeremy Chadwick 2014-11-02 19:51:58 UTC 
Can you explain a bit as to how the getline() stub is causing a problem?  Which version of FreeBSD are you using?

Rephrased: I'm fine with removing the stub (FreeBSD 8.x was EOL'd 2014/04/30), but I'd like to know how it's causing problems on newer FreeBSD when the #if defined(__FreeBSD__) && __FreeBSD_version < 800067 shouldn't get applied to newer FreeBSD.

Thank you!
Comment 4 ftigeot 2014-11-02 22:06:12 UTC 
The getline() stub is not causing a problem on recent FreeBSD versions per se.

Howewer, I'd like to build this port under DragonFly and adding -D__FreeBSD__ to CFLAGS would be the less invasive way to do that.

Unfortunately, the getline() stub still requires additional handling. By removing it from the FreeBSD port, I will be able to reduce differences with the DragonFly version to a minimum.
Comment 5 Jeremy Chadwick 2014-11-03 04:26:31 UTC 
Understood.  I'm fine with this patch replacing files/patch-config.c:

https://bugs.freebsd.org/bugzilla/attachment.cgi?id=148951

Could someone with commit access please go ahead and commit that?  (I don't know what the procedure is for this these days, since all the freebsd.org PR documentation still refers to the send-pr methodology and not Bugzilla).

Also, committer: please remove http://mirror.be.gbxs.net/pub/linux/utils/cpu/mce/ from MASTER_SITES in the Makefile.  That server doesn't respond on port 80 and hasn't for some time.
Comment 6 John Marino freebsd_committer freebsd_triage 2014-11-03 06:32:24 UTC 
I'll take it.
Comment 7 commit-hook freebsd_committer freebsd_triage 2014-11-03 06:59:46 UTC 
A commit references this bug:

Author: marino
Date: Mon Nov  3 06:58:45 UTC 2014
New revision: 372095
URL: https://svnweb.freebsd.org/changeset/ports/372095

Log:
  sysutils/mcelog: Remove patch for unsupported versions of FreeBSD

  PR:		194767
  Submitted by:	Francois Tigeot
  Approved by:	maintainer (Jeremy Chadwick)

Changes:
  head/sysutils/mcelog/files/patch-config.c
Comment 8 John Marino freebsd_committer freebsd_triage 2014-11-03 07:04:00 UTC 
done, thanks!
Comment 9 ftigeot 2014-11-03 08:54:27 UTC 
That was quick, thanks!