Created attachment 149391 [details] patch with IFT_FAITH conditionalized Hey, Attached is a new version of patch-noip2. As per <https://github.com/freebsd/freebsd/commit/b5d711d3a6940afdd3615f7ffc2dcfa3faacd446> faith(4) got removed from the kernel and headers. cheers, -sh
Maintainer CC'd
Would you like to update your mail address in the port Makefile or keep it?
The mail still works, was a mistake. Is the update PR otherwise well-formed? This is the first time it needs an update.
(In reply to sthalik from comment #3) > The mail still works, was a mistake. > > Is the update PR otherwise well-formed? This is the first time it needs an > update. Well, it's a small patch, so it would be easy for a committer to know how to proceed, but it's not quite how a patch should be submitted. For example: - Your patch changes the content of the default package, so you'd need to bump PORTREVISION - Your patch should be the output of "svn diff" relative to ${PORTSDIR}/dns/noip - It's always more than welcome if you attached poudriere build logs for supported architectures and releases - You should have tested the builds with default OPTIONS, with all OPTIONS selected and with all OPTIONS deselected Hope this helps
Created attachment 151149 [details] PR195002 dns/noip: Remove unnecessary interface type patch causing IFT_FAITH build errors Actually, the last hunk of dns/noip/files/patch-noip2.c which is the cause of this IFT_FAITH build error is no longer required. This patch was added to the FreeBSD ports tree a LONG time ago. It was there in October 2003 (around the time of FreeBSD 4.9 release), before FreeBSD had a version of PF or any of the interface types being excluded by that patch. Today, that part of the upstream code will work verbatim without any changes... so I have removed it with the attached patch. This patch that I have attached is intended replace the maintainers original patch attached to this bug report.
For a historical version of dns/noip/files/patch-noip2.c from October 2003, see the link below. https://svnweb.freebsd.org/ports/head/dns/noip/files/patch-noip2.c?revision=90325&view=markup For the interface types defined at the time of FreeBSD 4.9 release, see the link below. https://github.com/freebsd/freebsd/blob/release/4.9.0/sys/net/if_types.h
Successful Poudriere build logs using my replacement patch can be found here: http://woodsb02.no-ip.org/poudriere/build.html?mastername=101amd64-default&build=2014-12-31_18h49m41s http://woodsb02.no-ip.org/poudriere/build.html?mastername=101i386-default&build=2014-12-31_19h02m44s http://woodsb02.no-ip.org/poudriere/build.html?mastername=93amd64-default&build=2014-12-31_19h03m16s http://woodsb02.no-ip.org/poudriere/build.html?mastername=93i386-default&build=2014-12-31_19h10m00s http://woodsb02.no-ip.org/poudriere/build.html?mastername=84i386-default&build=2014-12-31_19h11m23s http://woodsb02.no-ip.org/poudriere/build.html?mastername=84amd64-default&build=2014-12-31_19h13m04s
As was spotted by Ben Woods, patching the file only to undo parts of the patch is obviously incorrect. Please use his patch provided instead, it was an omission to suggest including the #ifdef originally.
A commit references this bug: Author: adamw Date: Fri Jan 2 16:55:27 UTC 2015 New revision: 376054 URL: https://svnweb.freebsd.org/changeset/ports/376054 Log: Remove portions of patch relying upon faith(4) that are no longer necessary. PR: 195002 Submitted by: Stanislaw Halik (maintainer) Patch by: Ben Woods Approved by: maintainer Changes: head/dns/noip/Makefile head/dns/noip/files/patch-noip2.c
Committed. Thanks, Stanislaw and Ben!