Created attachment 149765 [details] Patch to update www/phpsysinfo to 3.1.16
Maintainer CC'd
Created attachment 149818 [details] www/phpsysinfo 3.1.16 buildlog
Looks good to me.
And thanks for submitting, Ralf! :)
Created attachment 150429 [details] Patch to update www/phpsysinfo to 3.1.17 Since this patch is obviously stuck in the void somewhere I might as well update to the latest one available
Do I need to perform any additional step to approve this? I am OK to go ahead with Ralf's 3.1.17 update. Thanks again Ralf!
patch is poudriere-tested and approved by maintainer. Move to patch-ready status.
this line in install target is most likely wrong: ${CHMOD} -R ${BINMODE} ${STAGEDIR}${WWWDIR} problem 1: chmod are supposed to be handle by @mode keyword in pkg-plist problem 2: The directory is full of gifs, text files, png, css, xml. There is no way those are supposed to be executable. Presumably the intent is to limit chmod changes to .php files only, most of which are in WWWDIR/includes. I think this is needs to be looked at. I'm moving this out of patch-ready. I'll handle it quickly once fixed.
Actually the line following the one you mention sets everything that's a file back to ${NOBINMODE}: ${FIND} ${STAGEDIR}${WWWDIR} ! -type d | ${XARGS} ${CHMOD} ${NOBINMODE} So basically what the two lines combined do, is set files to 444 and directories to 555. Moving all that to the pkg-plist is a lot more complicated than 2 simple lines, but I'll give it a go.
hmm, okay I didn't see the second line but are they really necessary? maybe it works fine without the lines at all if these are standard modes? It might be worth letting it build a package and extracting the package to see what it really looks like with no changes at all.
Created attachment 152620 [details] www/phpsysinfo 3.2.0 buildlog
Created attachment 152621 [details] Patch to update www/phpsysinfo to 3.2.0
I've removed the 2 lines from the Makefile and added @mode, @owner and @group to the pkg-plist. It's now in line with several other ports in www, like gallery2 and hastymail2. This also updates the port to the latest available version. New buildlog is also attached. To show that it's working look at http://sysinfo.cainites.net
your log is missing stage-qa checks. However, I ran the patch through poudriere myself and it passes fine.
A commit references this bug: Author: marino Date: Fri Feb 6 15:36:05 UTC 2015 New revision: 378545 URL: https://svnweb.freebsd.org/changeset/ports/378545 Log: www/phpsysinfo: Upgrade version from 3.0.10 => 3.2.0 PR: 195329 Submitted by: Ralf van der Enden Approved by: maintainer (Walt - relnor.com) Changes: head/www/phpsysinfo/Makefile head/www/phpsysinfo/distinfo head/www/phpsysinfo/pkg-plist
Done, thanks for your collective patience. :)