Created attachment 149779 [details] Replace libreiserfs-0.3.so as libreiserfs.so in Makefile. When PROGSREISERFS option is enabled, next line is evaluated. PROGSREISERFS_LIB_DEPENDS= libreiserfs-0.3.so:${PORTSDIR}/sysutils/progsreiserfs But, sysutils/progsreiserfs does not install ${LOCALBASE}/libreiserfs-0.3.so but ${LOCALBASE}/libreiserfs.so (symlink of ${LOCALBASE}/lib/libreiserfs-0.3.so.0.0.1). So, this can be revised as below. PROGSREISERFS_LIB_DEPENDS= libreiserfs.so:${PORTSDIR}/sysutils/progsreiserfs
Fix Summary and assign.
Ping ... It is still broken now even if the problem was found almost two years ago. Can it be reviewed and fixed soon?
Maintainer feedback?
After 3 years I'm surprised this hasn't been landed with maintainer timeout :-) Actually, I'm surprised my ports haven't been reassigned to ports@. Mark: Can you do that when you've got a minute? I haven't touched ports in 7 years at this point and I've got no prospect of free time to do so in the near future.
You are right, I think it is maintainer timeout!
Created attachment 191247 [details] Patch for testdisk 7.1 WIP with fix for libreiserfs.so Hello, testdisk has been updated to 7.1 WIP meanwhile. I've created a updated version of the patch which does following: - fixes the libreiserfs.so issue - updates testdisk to 7.1 WIP Changes to the port: - changed PORTVERSION to DISTVERSION - place port back to the pool - removed entries that were already commented out - removed post-patch target because it isn't needed anymore - removed "*/qphotorec*" entries from PLIST_FILES to pass Stage-QA QA: ~~~ - poudriere (11.1-RELEASE amd64 + i386) -> OK - portlint -> OK Note: ~~~~~ A disk device must be given manually as argument to testdisk/photorec. It seems that disks can't be detected automatically.
A commit references this bug: Author: tobik Date: Tue Mar 6 12:09:59 UTC 2018 New revision: 463720 URL: https://svnweb.freebsd.org/changeset/ports/463720 Log: sysutils/testdisk: Fix build with PROGREISERFS=on Fix LIB_DEPENDS: libreiserfs-0.3.so does not exist PR: 195339 Submitted by: crest@sahiro.org Approved by: flz (maintainer) Changes: head/sysutils/testdisk/Makefile
A commit references this bug: Author: tobik Date: Tue Mar 6 12:23:43 UTC 2018 New revision: 463721 URL: https://svnweb.freebsd.org/changeset/ports/463721 Log: sysutils/testdisk: Update to 7.1-WIP PR: 195339 Submitted by: freebsd_ports@k-worx.org (based on) Changes: head/sysutils/testdisk/Makefile head/sysutils/testdisk/distinfo
A commit references this bug: Author: tobik Date: Tue Mar 6 12:32:02 UTC 2018 New revision: 463723 URL: https://svnweb.freebsd.org/changeset/ports/463723 Log: Reset MAINTAINER of flz's ports by his request PR: 195339 Changes: head/net/grdesktop/Makefile head/net/ldapsh/Makefile head/net-im/py-jabber/Makefile head/net-p2p/bnbt/Makefile head/net-p2p/libbt/Makefile head/security/openbsm/Makefile head/www/feedjack/Makefile head/www/visitors/Makefile head/x11/wmctrl/Makefile head/x11-themes/icons-tango-extras/Makefile head/x11-wm/tinywm/Makefile
A commit references this bug: Author: tobik Date: Tue Mar 6 12:33:51 UTC 2018 New revision: 463724 URL: https://svnweb.freebsd.org/changeset/ports/463724 Log: MFH: r463720 sysutils/testdisk: Fix build with PROGREISERFS=on Fix LIB_DEPENDS: libreiserfs-0.3.so does not exist PR: 195339 Submitted by: crest@sahiro.org Approved by: flz (maintainer) Approved by: ports-secteam blanket Changes: _U branches/2018Q1/ branches/2018Q1/sysutils/testdisk/Makefile
Ok, committed both patches and reset flz's ports. Thanks! (In reply to owk from comment #6) 7.1-WIP is a pre-release version and we shouldn't misrepresent it as being version 7.1, so I set DISTVERSION=7.1-WIP (=> PORTVERSION=7.1.w) instead. This way we won't need to bump PORTREVISION when 7.1 is actually released since 7.1.w < 7.1 according to `pkg version -t 7.1.w 7.1`.
Thanks tobik!