Bug 195437 - [patch] [revive port] stagify print/lgrind
Summary: [patch] [revive port] stagify print/lgrind
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-27 01:58 UTC by Henry Hu
Modified: 2014-12-18 19:56 UTC (History)
2 users (show)

See Also:

Attachments
stagify lgrind (10.86 KB, patch)
2014-11-27 01:58 UTC, Henry Hu 		no flags Details | Diff
2nd ver (10.68 KB, patch)
2014-12-03 05:30 UTC, Henry Hu 		no flags Details | Diff
3rd version (11.32 KB, patch)
2014-12-17 00:34 UTC, Henry Hu 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Henry Hu 2014-11-27 01:58:34 UTC 
Created attachment 149927 [details]
stagify lgrind

print/lgrind was removed because of no stage. Now stage it.
Comment 1 John Marino freebsd_committer freebsd_triage 2014-11-28 16:24:57 UTC 
@dirrm/try lines in pkg-plist are not allowed.
Please remove those and provide poudriere testport logs as proof that the port would conform to current tree standards.
Comment 2 Henry Hu 2014-12-03 05:30:24 UTC 
Created attachment 150132 [details]
2nd ver

2nd version, removed @dirrm lines.
I'm waiting for redports to come back, so I can test the ports there.
Comment 3 John Marino freebsd_committer freebsd_triage 2014-12-03 07:52:19 UTC 
even if it were available, redports is not useful for "QA" work.  As long as the backend is tinderbox, it can't test the port for anything other than "it builds" and even then it gives misleading results (e.g. shows leftover when there aren't any).  This is why I said "poudriere" and specifically did not mention redports as an alternative.

At the very least, you need to run the following commands and provide their outputs here.

> portlint
> make check-plist
> make stage-qa
Comment 4 Pawel Pekala freebsd_committer freebsd_triage 2014-12-16 16:44:13 UTC 
Fails stage Q/A:

====> Running Q/A tests (stage-qa)
Error: 'bin/lgrind' is referring to /usr/local/ports/print/lgrind/work/stage
*** Error code 1
Comment 5 Henry Hu 2014-12-17 00:34:50 UTC 
Created attachment 150661 [details]
3rd version

fix the reference to lgrindef file in stage dir in lgrind.
Comment 6 commit-hook freebsd_committer freebsd_triage 2014-12-18 19:50:08 UTC 
A commit references this bug:

Author: pawel
Date: Thu Dec 18 19:50:00 UTC 2014
New revision: 374916
URL: https://svnweb.freebsd.org/changeset/ports/374916

Log:
  - Revive print/lgrind, now distributed as one file
  - Add new mastersite, homepage, staging support
  - Clean pkg-plist

  PR:		195437
  Submitted by:	Henry Hu <henry.hu.sh@gmail.com>

Changes:
  head/print/Makefile
  head/print/lgrind/
  head/print/lgrind/Makefile
  head/print/lgrind/distinfo
  head/print/lgrind/files/
  head/print/lgrind/files/patch-Makefile
  head/print/lgrind/files/patch-lgutil_c
  head/print/lgrind/files/patch-source_Makefile
  head/print/lgrind/files/patch-source_lgrind.c
  head/print/lgrind/files/patch-source_regexp.c
  head/print/lgrind/pkg-descr
  head/print/lgrind/pkg-plist