Bug 195487 - [PATCH] shells/fish: remove redundant pkg-deinstall script
Summary: [PATCH] shells/fish: remove redundant pkg-deinstall script
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jason Helfman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-28 21:56 UTC by braakvaak
Modified: 2014-12-09 21:31 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (freebsd.users)

Attachments
diff (363 bytes, patch)
2014-11-28 21:56 UTC, braakvaak 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description braakvaak 2014-11-28 21:56:25 UTC 
Created attachment 149980 [details]
diff

This port uses the @shell keyword in pkg-plist so the deinstall script is now redundant. This deinstall script also causes /etc/shells to double in size, because it appends the contents of shells.bak to it.

Commands:
svn remove pkg-deinstall
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-11-28 21:56:25 UTC 
Maintainer CC'd
Comment 2 freebsd.users 2014-12-09 02:12:41 UTC 
This patch is fine for me. Please commit.
Comment 3 Jason Helfman freebsd_committer freebsd_triage 2014-12-09 21:30:26 UTC 
Committed, thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2014-12-09 21:31:05 UTC 
A commit references this bug:

Author: jgh
Date: Tue Dec  9 21:30:14 UTC 2014
New revision: 374430
URL: https://svnweb.freebsd.org/changeset/ports/374430

Log:
  - drop redundant and erroneous cleanup of shell listing in /etc/shells

  PR:		195487
  Submitted by:	braakvaak@aol.com
  Approved by:	freebsd.users@gmail.com (maintainer)

Changes:
  head/shells/fish/Makefile
  head/shells/fish/pkg-deinstall