Bug 195654 - net-im/qTox: add databases/qt5-sqldrivers-sqlite3 missing dependency
Summary: net-im/qTox: add databases/qt5-sqldrivers-sqlite3 missing dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thierry Thomas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-03 20:55 UTC by Igor Ostapenko
Modified: 2014-12-04 22:41 UTC (History)
4 users (show)

See Also:
thierry: maintainer-feedback+

Attachments
qTox-0.141118.diff (528 bytes, patch)
2014-12-03 20:55 UTC, Igor Ostapenko 		no flags Details | Diff
updated patch (574 bytes, patch)
2014-12-04 01:51 UTC, Yuri Victorovich 		yuri: maintainer-approval-
Details | Diff
poudriere log (181.95 KB, text/plain)
2014-12-04 01:53 UTC, Yuri Victorovich 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Igor Ostapenko freebsd_committer freebsd_triage 2014-12-03 20:55:46 UTC 
Created attachment 150153 [details]
qTox-0.141118.diff

If devel/qt5 meta port is installed with default options then this driver will be around, otherwise qTox ends up be running w/o it, what leads to crashes upon posting/etc, i.e. when it tries to hit its *db files.
The attached patch example makes qTox happy w/o full devel/qt5.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-12-03 20:55:46 UTC 
Maintainers CC'd
Comment 2 Thierry Thomas freebsd_committer freebsd_triage 2014-12-03 22:09:51 UTC 
Waiting for maintainer's approval.
Comment 3 Max Brazhnikov freebsd_committer freebsd_triage 2014-12-03 22:43:49 UTC 
Please add _run suffix to sql-sqlite3 and _build to linguisttools.
See http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/using-qt.html#qt-components for details.
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2014-12-04 01:51:13 UTC 
Created attachment 150169 [details]
updated patch

Thanks Igor and Max, I integrated both suggestions into this 'updated patch'.
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2014-12-04 01:53:37 UTC 
Created attachment 150170 [details]
poudriere log
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2014-12-04 01:55:37 UTC 
In pourdriere log, please ignore:

> ====> Running Q/A tests (stage-qa)
> Warning: dependency file /usr/local/lib/libGL.so.1 doesn't belong to any package

This is from the new test I have locally, not in the head.
Comment 7 commit-hook freebsd_committer freebsd_triage 2014-12-04 22:40:52 UTC 
A commit references this bug:

Author: thierry
Date: Thu Dec  4 22:40:44 UTC 2014
New revision: 373988
URL: https://svnweb.freebsd.org/changeset/ports/373988

Log:
  Add databases/qt5-sqldrivers-sqlite3 missing dependency.

  PR:		ports/195654
  Submitted by:	Igor Ostapenko
  Approved by:	maintainer (yuri)

Changes:
  head/net-im/qTox/Makefile
Comment 8 Thierry Thomas freebsd_committer freebsd_triage 2014-12-04 22:41:16 UTC 
Committed, thanks!