Created attachment 150280 [details] diff -ruN output FreeBSD does not have Xft support for dzen2 and it is buggy in upstream that's why I made a patch to make it work in the port. Please note that I notified upstream about the patch, but I am not sure if it will ever be processed. After applying patch, please check if the folowing patches have been removed: * files/patch-gadgets__config.mk * files/patch-gadgets__kittscanner.sh The following new patch should be included (it can be safely applied whether Xft is enabled or not): * files/patch-Xft The original sources are now on Github. I forked the branch and you would get the sources like they are in https://github.com/nakal/dzen (after the patch above). BUT PLEASE DON'T LINK TO MY FORK, BECAUSE I WANT TO HAVE THE FREEDOM TO REMOVE IT!
Maintainer CC'd
Comment on attachment 150280 [details] diff -ruN output Thanks for update! But I've a question: do you think this git-version is enough stable and usable? I didn't try it.
Cannot tell for sure. It is running well on my amd64 (I don't have anything else than this platform) and I will submit further patches, if needed. The author also does not use tags in his repo and there are 3 further patches pending, the oldest one since 6 months. I've had a quick look over the entire sources to see if there are any obvious evil things. I haven't found anything suspicious. The sources look clean except for the entire function that I made a patch for. A bit messy there. I also haven't checked the entire functionality with all switches and all configuration commands, but I am using some reasonable subset of it and there are no problems so far with it.
Why did you delete files/patch-gadgets__config.mk? In directory `gadgets' exists an another config.mk.
You are right, I made a mistake. It breaks the GADGETS switch. Put files/patch-gadgets__config.mk back into the port directory, please.
Oh, ok :) I've made some clarifications of your diff.
Created attachment 150304 [details] updated patch Diff with original patch: - doesn't need DISTNAME and update distinfo - disable deleting of patch-gadgets__config.mk - update WWW - added Xft to use_xorg if it's enabled Changelog: - updated to 0.9.5 - added Xft support
I verified your updated patch. It works for me. Thanks.
Thanks (and your work too). I think can push into ports tree.
One month almost passed. Is this going to be committed?
Yes, it can commit. But I don't have write access to port tree, I'm "only" a maintainer. Should wait a committer.
Zsolt, this is a significant patch (it upgrades the version). Can you provide a poudriere log? I updated the subject which will make this PR more visible.
I don't use poudriere but I can attach output of 'make stage stage-qa check-plist'.
Created attachment 152154 [details] Build log make stage stage-qa check-plist
(In reply to Zsolt Udvari from comment #13) "I don't use poudriere" As active as you are in ports, you should rectify that soon. poudriere tests more and running those tests on a live system can't really trusted. In other words, it's better than nothing, but not 100% trustworthy. I've seen passing output utterly fail on poudriere due to missing / uninstalled software in the clean jail. Anyway, I'll promote based on maintainer timeout, but think about installing poudriere soon. :)
(In reply to John Marino from comment #15) Okay, I'll implement soon :)
Zsolt, see what I mean? --- dzen2 --- LD dzen2 pkg-config: not found draw.o: In function `parse_line': draw.c:(.text+0x2f2): undefined reference to `XftDrawCreate' draw.c:(.text+0x688): undefined reference to `XftTextExtentsUtf8' draw.c:(.text+0x735): undefined reference to `XftTextExtentsUtf8' draw.c:(.text+0x934): undefined reference to `XftColorAllocName' draw.c:(.text+0x981): undefined reference to `XftDrawStringUtf8' draw.c:(.text+0x1a5f): undefined reference to `XftDrawDestroy' draw.o: In function `setfont': draw.c:(.text+0x1b32): undefined reference to `XftFontClose' draw.c:(.text+0x1b47): undefined reference to `XftFontOpenXlfd' draw.c:(.text+0x1b6b): undefined reference to `XftFontOpenName' draw.c:(.text+0x1bc6): undefined reference to `XftTextExtentsUtf8' cc: error: linker command failed with exit code 1 (use -v to see invocation) *** [dzen2] Error code 1 make[1]: stopped in /wrkdirs/usr/ports/x11/dzen2/work/robm-dzen-488ab66 It looks like there is at least two problems with this port. (missing pkgconfig and xft not specified). If this doesn't convince you about poudriere, nothing will. :)
all it needed was "USES= pkgconfig". xft was already specified, it just couldn't be found.
A commit references this bug: Author: marino Date: Fri Feb 6 11:58:34 UTC 2015 New revision: 378528 URL: https://svnweb.freebsd.org/changeset/ports/378528 Log: x11/dzen2: Upgrade version 0.8.5 => 0.9.5 PR: 195756 Submitted by: maintainer (martin - sugioarto.com) Assisted by: Zsolt Udvari Changes: head/x11/dzen2/Makefile head/x11/dzen2/distinfo head/x11/dzen2/files/patch-Xft head/x11/dzen2/files/patch-gadgets__kittscanner.sh head/x11/dzen2/pkg-descr
thanks, sorry about the delay.
(In reply to John Marino from comment #20) Thanks! I don't have time now (for some weeks) to set up poudriere.