Hello, I'm using the precompiled packages and password-store. The default configuration does not enable contribution files for password-store like shell completion. I think it would be useful for other people as well to enable them assuming that this will not need a lot of memory. Thanks!
Auto-assigned to maintainer milki@FreeBSD.org
This is probably outdated as AFAICT package 1.6.3_2 installed by `pkg install` *does* have the shell completions files installed as: % pkg info -l password-store | fgrep completion /usr/local/share/password-store/pass.bash-completion /usr/local/share/password-store/pass.fish-completion /usr/local/share/password-store/pass.zsh-completion but I think it would be even nicer to install them in the directory where they are automatically found & used, example given how I do in my devel/monotone port: % pkg info -l monotone | egrep 'zsh/|/bash' /usr/local/etc/bash_completion.d/monotone.bash_completion /usr/local/share/zsh/site-functions/_mtn
That's interesting. These files don't show up for me: % pkg info -l password-store password-store-1.6.3_2: /usr/local/bin/pass /usr/local/libexec/pass /usr/local/man/man1/pass.1.gz /usr/local/share/examples/password-store/example-filter.sh /usr/local/share/licenses/password-store-1.6.3_2/GPLv2 /usr/local/share/licenses/password-store-1.6.3_2/LICENSE /usr/local/share/licenses/password-store-1.6.3_2/catalog.mk I'm using the quarterly branch, does this matter? As it's the beginning of a new quarter it isn't really old.
Sorry, you're right: % tar tf /var/cache/pkg/password-store-1.6.3_2.txz +COMPACT_MANIFEST +MANIFEST /usr/local/share/licenses/password-store-1.6.3_2/catalog.mk /usr/local/share/licenses/password-store-1.6.3_2/LICENSE /usr/local/share/licenses/password-store-1.6.3_2/GPLv2 /usr/local/man/man1/pass.1.gz /usr/local/share/examples/password-store/example-filter.sh /usr/local/bin/pass /usr/local/libexec/pass âĶI probably used portmaster and then wiped the information from my brain (I could have sworn I didn't). In this case, I'm also all for adding that as a default.
Thanks for the suggestion. If other ports install the completion files, I can do that as well. I'll take a peek at monotone.
I've looked at a couple different ports. I'm opting for installing all the completions (bash, zsh, fish) when CONTRIB is checked. Review: https://reviews.freebsd.org/D4208
A commit references this bug: Author: rene Date: Tue May 31 16:24:28 UTC 2016 New revision: 416209 URL: https://svnweb.freebsd.org/changeset/ports/416209 Log: sysutils/password-store: update to version 1.6.5 - enable shell completions by default (bash, fish, zsh) [1] - do not remove XClip and GIT functionality [2] PR: 195951 [1] Submitted by: rs.os@t-online.de [1], milki [2] Reviewed by: milki [2], eadler [2] Differential Revision: https://reviews.freebsd.org/D4208 [2] (to 1.6.4) Changes: head/sysutils/password-store/Makefile head/sysutils/password-store/distinfo head/sysutils/password-store/files/ head/sysutils/password-store/pkg-plist