Bug 196008 - [maintainer-update] net-mgmt/seafile: correct code for usage of P_KTHREADP
Summary: [maintainer-update] net-mgmt/seafile: correct code for usage of P_KTHREADP
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: John Marino
URL:
Keywords:
: 196007 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-12-16 01:17 UTC by Jingfeng Yan
Modified: 2014-12-18 07:43 UTC (History)
2 users (show)

See Also:

Attachments
patch (1.45 KB, patch)
2014-12-16 01:24 UTC, Jingfeng Yan 		no flags Details | Diff
patch (865 bytes, patch)
2014-12-16 01:25 UTC, Jingfeng Yan 		no flags Details | Diff
patch (865 bytes, patch)
2014-12-16 01:26 UTC, Jingfeng Yan 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jingfeng Yan 2014-12-16 01:17:52 UTC 
The P_KTHREADP never works in DragonflyBSD. In its 4.0 kernel, the marco has been removed.  It should use P_SYSTEM instead.
Comment 1 Jingfeng Yan 2014-12-16 01:24:06 UTC 
Created attachment 150617 [details]
patch
Comment 2 Jingfeng Yan 2014-12-16 01:25:33 UTC 
Created attachment 150618 [details]
patch
Comment 3 Jingfeng Yan 2014-12-16 01:26:18 UTC 
Created attachment 150619 [details]
patch
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2014-12-16 03:20:48 UTC 
*** Bug 196007 has been marked as a duplicate of this bug. ***
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-12-16 12:42:42 UTC 
A commit references this bug:

Author: marino
Date: Tue Dec 16 12:41:56 UTC 2014
New revision: 374802
URL: https://svnweb.freebsd.org/changeset/ports/374802

Log:
  net-mgmt/seafile: Fix kernel thread support on DragonFly

  PR:		196008
  Submitted by:	maintainer

Changes:
  head/net-mgmt/seafile/Makefile
  head/net-mgmt/seafile/files/patch-lib_utils.c
Comment 6 John Marino freebsd_committer freebsd_triage 2014-12-16 13:17:56 UTC 
Thanks!
Comment 7 Jingfeng Yan 2014-12-16 13:37:19 UTC 
(In reply to John Marino from comment #6)
> Thanks!

Welcome, Do you commit the similar thing for 196006 (ccnet)?
Comment 8 John Marino freebsd_committer freebsd_triage 2014-12-16 14:25:13 UTC 
no, i haven't fixed ccnet yet.  If you could give me a patch, I'll do it right away. :)
Comment 9 Jingfeng Yan 2014-12-16 22:18:08 UTC 
(In reply to John Marino from comment #8)
> no, i haven't fixed ccnet yet.  If you could give me a patch, I'll do it
> right away. :)

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196006
Comment 10 Jingfeng Yan 2014-12-18 07:43:50 UTC 
(In reply to Jingfeng Yan from comment #9)
> (In reply to John Marino from comment #8)
> > no, i haven't fixed ccnet yet.  If you could give me a patch, I'll do it
> > right away. :)
> 
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196006


For this commit, it triggers some odd format issue maybe.  I did not hit them during normal build in FreeBSD 9.1-p22 (build from scratch in virtual machine), and FreeBSD 9.3-p?.  I am reproducing the issue in pouderier. Hopefully, I can catch it.