Bug 196067 - [PATCH] lang/php53 fails to build on armv6
Summary: [PATCH] lang/php53 fails to build on armv6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Many People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-17 16:33 UTC by Mikael Urankar
Modified: 2014-12-31 00:55 UTC (History)
2 users (show)

See Also:
sbruno: maintainer-feedback?

Attachments
files/patch-Zend_zend__ini.h (392 bytes, text/x-chdr)
2014-12-17 16:33 UTC, Mikael Urankar 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer freebsd_triage 2014-12-17 16:33:06 UTC 
Created attachment 150684 [details]
files/patch-Zend_zend__ini.h

Current build error:
/wrkdirs/usr/ports/lang/php53/work/php-5.3.29/ext/date/php_date.c:516:88: error: unexpected type name 'zend_date_globals': expected expression
        STD_PHP_INI_ENTRY("date.timezone", "", PHP_INI_ALL, OnUpdateString, default_timezone, zend_date_globals, date_globals)

It was fixed upstream by this commit:
http://git.php.net/?p=php-src.git;a=commitdiff;h=050aae2860e1c202e2e9db715beaa97d0a4c9c33;hp=e67a2b9e471a7bc0b774b9056bb38745b7187969#patch1

Put the attached file in lang/php53/files

build log on armv6:
http://mikael.urankar.free.fr/FreeBSD/arm/build_logs/php53-5.3.29_2.log
Comment 2 commit-hook freebsd_committer freebsd_triage 2014-12-31 00:36:00 UTC 
A commit references this bug:

Author: sbruno
Date: Wed Dec 31 00:35:23 UTC 2014
New revision: 375867
URL: https://svnweb.freebsd.org/changeset/ports/375867

Log:
  Fix build for armv6 with an upstream commit:
  http://git.php.net/?p=php-src.git;a=commitdiff;h=050aae2860e1c202e2e9db715beaa97d0a4c9c33;hp=e67a2b9e471a7bc0b774b9056bb38745b7187969#patch1

  PR:		196067
  Submitted by:	mikael.urankar@gmail.com
  Reviewed by:	flo@
  Approved by:	mentor (implicit)

Changes:
  head/lang/php53/Makefile
  head/lang/php53/files/patch-Zend_zend__ini.h