Created attachment 150934 [details] Build ortp with srtp and zrtp support The port currently builds with support for neither srtp nor zrtp protocols, which leads to encryption being unavailable in linphone. This patch -- to be applied after the Bug 196248 is resolved as I expect -- will make use of both libsrtp and libzrtpcpp in ortp.
Created attachment 151191 [details] alternate patch net/ortp only needs libzrtpcppcore instead of libzrtpcpp. I've created a new port security/libzrtpcppcore which net/ortp can depend on. This patch also makes the SRTP and ZRTP support optional. CPPFLAGS+=-DHAVE_DEV_RANDOM can also be removed because on FreeBSD arc4random is used instead of /dev/random.
(In reply to Tijl Coosemans from comment #1) > net/ortp only needs libzrtpcppcore instead of libzrtpcpp. I've created a > new port security/libzrtpcppcore which net/ortp can depend on. I don't know, if that was wise -- are there a lot of use-cases, where only libzrtpcppcore is needed? Is libzrtpcpp MUCH bigger and/or does it require many more dependencies? > This patch also makes the SRTP and ZRTP support optional. Is this warranted? You have enabled them by default, which is good, but should they be optional -- and require the users to answer yet more questions, when building? Why would anybody want to disable them?
(In reply to Mikhail T. from comment #2) > (In reply to Tijl Coosemans from comment #1) >> net/ortp only needs libzrtpcppcore instead of libzrtpcpp. I've created a >> new port security/libzrtpcppcore which net/ortp can depend on. > > I don't know, if that was wise -- are there a lot of use-cases, where only > libzrtpcppcore is needed? Is libzrtpcpp MUCH bigger and/or does it require > many more dependencies? libzrtpcppcore does not have any dependencies. It is purely about ZRTP, while libzrtpcpp depends on ccrtp (and its dependencies) and is about SRTP+ZRTP. Since net/ortp used libsrtp for SRTP support, it only needs libzrtpcppcore. >> This patch also makes the SRTP and ZRTP support optional. > > Is this warranted? You have enabled them by default, which is good, but > should they be optional -- and require the users to answer yet more > questions, when building? Why would anybody want to disable them? libzrtpcppcore is now LGPL3 instead of GPL3, so yes, maybe it doesn't need to be optional.
(In reply to Tijl Coosemans from comment #3) Tijl, please, go ahead in the fashion you deem best -- I think, you've given this a lot of thought. All I really care for is to have an encryption-capable linphone :-) BTW, perhaps, you should take maintainership of the linphone port? Thank you!
Any advance here? and is it still relevant?
SRTP/ZRTP support has been moved from oRTP to Mediastreamer.