Created attachment 151193 [details] change non-existent umount call to unmount If owfs option is selected comms/owfs fails to build with the following message: gmake-lite[6]: Entering directory '/usr/ports/comms/owfs/work/owfs-2.9p8/module/owfs/src/c' /bin/sh ../../../../libtool --tag=CC --mode=link cc -I../include -DFUSE_USE_VERSION=26 -I/usr/local/include -I../../../owlib/src/include -L../../../owlib/src/c -fexceptions -Wall -W -Wundef -Wshadow -Wpointer-arith -Wcast-qual -Wcast-align -Wstrict-prototypes -Wredundant-decls -D_FILE_OFFSET_BITS=64 -D_XOPEN_SOURCE=600 -D_BSD_SOURCE=1 -D_ISOC99_SOURCE=1 -D_POSIX_C_SOURCE=200112L -D_THREAD_SAFE -pthread -O2 -pipe -march=core2 -fstack-protector -fno-strict-aliasing -DNO_NESTED_FUNCTIONS -D_XOPEN_SOURCE=600 -D_BSD_SOURCE=1 -D_ISOC99_SOURCE=1 -D_POSIX_C_SOURCE=200112L -lusb -fstack-protector -o owfs owfs.o owfs_callback.o fuse_line.o -low -L/usr/local/lib -lfuse -lusb -lrt -lm libtool: link: cc -I../include -DFUSE_USE_VERSION=26 -I/usr/local/include -I../../../owlib/src/include -fexceptions -Wall -W -Wundef -Wshadow -Wpointer-arith -Wcast-qual -Wcast-align -Wstrict-prototypes -Wredundant-decls -D_FILE_OFFSET_BITS=64 -D_XOPEN_SOURCE=600 -D_BSD_SOURCE=1 -D_ISOC99_SOURCE=1 -D_POSIX_C_SOURCE=200112L -D_THREAD_SAFE -pthread -O2 -pipe -march=core2 -fstack-protector -fno-strict-aliasing -DNO_NESTED_FUNCTIONS -D_XOPEN_SOURCE=600 -D_BSD_SOURCE=1 -D_ISOC99_SOURCE=1 -D_POSIX_C_SOURCE=200112L -fstack-protector -o .libs/owfs owfs.o owfs_callback.o fuse_line.o -L../../../owlib/src/c /usr/ports/comms/owfs/work/owfs-2.9p8/module/owlib/src/c/.libs/libow.so -L/usr/local/lib -lfuse -lusb -lrt -lm -pthread -Wl,-rpath -Wl,/usr/local/lib owfs.o: In function `main': owfs.c:(.text+0x29d): undefined reference to `umount' cc: error: linker command failed with exit code 1 (use -v to see invocation) Makefile:538: recipe for target 'owfs' failed gmake-lite[6]: *** [owfs] Error 1 The attached patch changes umount call to unmount and allows the build to complete
Maintainer CC'd
Thanks, no objections on the patch. Does FuseFS-OWFS fully work after this, and if so on what FreeBSD versions (although I guess only 10.x is relevant nowadays, since older are EOL)? I wont have time to make a proper patch and submission of the port for the next few weeks. Either wait for me (or possibly some freebsd maint) to do it, or please create a port patch yourself. Johan
It works for me (using it for DS18S20 temperature sensors on stable/10). I can reproduce the problem using poudriere with 10.0-RELEASE and the patch helps there too.
It is actually a port patch originally named patch-module_owfs_src_c_owfs.c I'm using it with my port tree.
Ah, I missed that. Great, then any commiter may add the patch to the ports tree.
A commit references this bug: Author: riggs Date: Sat Jan 3 16:56:19 UTC 2015 New revision: 376126 URL: https://svnweb.freebsd.org/changeset/ports/376126 Log: Fix build with non-default OPTION owfs PR: 196421 Submitted by: osidorkin@gmail.com Approved by: johan@stromnet.se (maintainer) MFH: 2015Q1 Changes: head/comms/owfs/files/ head/comms/owfs/files/patch-module_owfs_src_c_owfs.c
A commit references this bug: Author: riggs Date: Mon Jan 5 08:46:11 UTC 2015 New revision: 376283 URL: https://svnweb.freebsd.org/changeset/ports/376283 Log: MFH: r376126 Fix build with non-default OPTION owfs PR: 196421 Submitted by: osidorkin@gmail.com Approved by: ports-secteam (rea), johan@stromnet.se (maintainer) Changes: _U branches/2015Q1/ branches/2015Q1/comms/owfs/files/