Created attachment 151431 [details] svn patch Hi, In case of WITH_DEBUG=YES, graphics/svgalib build is broken using clang (at least under FreeBSD 10.1). The root cause is different behaviour of "inline" in GNU89 & C99: http://clang.llvm.org/compatibility.html#inline. As quick fix, the attached patch adds "static" for inline function outb. The issue is reproduced only if cc doesn't do optimization like removal of inline function. If you define WITH_DEBUG as yes, cc will use -O0 instead of -O2. Please find attached patch to fix this issue. Patch is verified by poudriere, log is attached.
Auto-assigned to maintainer zeising@FreeBSD.org
Created attachment 151432 [details] poudriere log
This is still a valid failure case and fix. I'll commit this if the maintainer doesn't have time for it: gmake[2]: Entering directory '/wrkdirs/usr/ports/graphics/svgalib/work/svgalib-1.4.3/utils' cc -I/wrkdirs/usr/ports/graphics/svgalib/work/svgalib-1.4.3/include -I. -MM /wrkdirs/usr/ports/graphics/svgalib/work/svgalib-1.4.3/utils/restorefont.c /wrkdirs/usr/ports/graphics/svgalib/work/svgalib-1.4.3/utils/convfont.c /wrkdirs/usr/ports/graphics/svgalib/work/svgalib-1.4.3/utils/restoretextmode.c /wrkdirs/usr/ports/graphics/svgalib/work/svgalib-1.4.3/utils/restorepalette.c /wrkdirs/usr/ports/graphics/svgalib/work/svgalib-1.4.3/utils/dumpreg.c /wrkdirs/usr/ports/graphics/svgalib/work/svgalib-1.4.3/utils/fix132x43.c /wrkdirs/usr/ports/graphics/svgalib/work/svgalib-1.4.3/utils/setmclk.c >.depend cc -Wall -Wstrict-prototypes -Wall -Wstrict-prototypes -fPIC -I/wrkdirs/usr/ports/graphics/svgalib/work/svgalib-1.4.3/include -I. -pipe -g -fstack-protector -fno-strict-aliasing -I../include -c -o restorefont.o restorefont.c cc -Wall -Wstrict-prototypes -Wall -Wstrict-prototypes -fPIC -I/wrkdirs/usr/ports/graphics/svgalib/work/svgalib-1.4.3/include -I. -pipe -g -fstack-protector -fno-strict-aliasing -I../include -L../sharedlib -o restorefont restorefont.o -lvga -lm ../sharedlib/libvga.so: undefined reference to `_outb' cc: error: linker command failed with exit code 1 (use -v to see invocation) /wrkdirs/usr/ports/graphics/svgalib/work/svgalib-1.4.3/utils/Makefile:34: recipe for target 'restorefont' failed gmake[2]: *** [restorefont] Error 1 gmake[2]: Leaving directory '/wrkdirs/usr/ports/graphics/svgalib/work/svgalib-1.4.3/utils' Makefile:423: recipe for target 'textutils' failed gmake[1]: *** [textutils] Error 2 gmake[1]: Leaving directory '/wrkdirs/usr/ports/graphics/svgalib/work/svgalib-1.4.3' *** Error code 2
Looking good to me. Consider this maintainer approval to commit this. I'll try to get to it this evening otherwise.
A commit references this bug: Author: zeising Date: Thu Jul 16 21:29:36 UTC 2015 New revision: 392325 URL: https://svnweb.freebsd.org/changeset/ports/392325 Log: Break build when WITH_DEBUG= is set PR: 196576 Submitted by: mizhka@gmail.com Changes: head/graphics/svgalib/files/patch-src-paradise.c
A commit references this bug: Author: acm Date: Mon Aug 27 02:36:05 UTC 2018 New revision: 478173 URL: https://svnweb.freebsd.org/changeset/ports/478173 Log: - Set LLD_UNSAFE PR: 196576 Submitted by: emaste, darkfiberiru at gmail.com Changes: head/editors/lazarus/Makefile