Stendhal is a 2D massively multiplayer online role playing game. It is written in Java and is playable on multiple platforms. This port allows building the client and/or server. http://stendhalgame.org/ The game is built on the Marauroa engine. Both are developed by the Arianne project (http://arianne.sourceforge.net/). I previously created a Port for Marauroa (196611: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196611) but found that there were some bugs. For now Stendhal comes bundled with the Marauroa runtime but I would eventually like to separate the two.
Hi, Due to an issue with the backend FreeBSD Bugzilla database, your original PR and any updates to it since have been lost. I've recreated the original PR as best as I can, however any attachments and updates you submitted to the PR have been lost. Please could you resubmit them? Thanks, and apologies.
Created attachment 151527 [details] Shell archive for games/stendhal No problem. :)
If this Port is accepted I would like to be maintainer, if that is okay.
- Please include extra files (desktop file (for which you may also use DESKTOP_ENTRIES), runserver.sh) as plain files under files/. Composing the in the makefile is unreadable (1) - Please consider using USE_ANT - Straightforward conditional installation of files in the target will likely be simpler and shorter than what you do with COMMON{DATA,LIBS,JARS} - Why do you alias DATADIR as TMPDIR? - In installation you should use COPYTREE_* macros instead of cp -R, ${CHMOD} instead of chmod and ${PRINTF} instead of printf. Though you probably don't need printf, as per (1) - Conditions in do-install should be ones from make, not shell. E.g. .if ${PORT_OPTIONS:MCLIENT} ... .endif - Why does this NEED_ROOT?
I'll get to work fixing these issues as soon as I can.
Note that in the shell archive I submitted it already has "USE_ANT=yes".
About the "NEED_ROOT", I was just unclear about what it actually does. According the Porter's Handbook here https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html, at least how I understood it, if the command "make package" fails as a normal user (which it did for me) then "NEED_ROOT=yes" is to be added to the Makefile. Doing so did not help anything though, so I guess I will just remove it.
Sorry about that last link to the handbook. Here is the section i was referring to: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#porting-testing
Created attachment 154175 [details] r3: shell archive for games/stendhal COPYTREE_* macros copy the entire directory structure. So, instead of installing to work/stage/usr/local/share/stendhal/doc it installs to work/stage/usr/local/share/stendhal/doc/usr/ports/games/stendhal/work/stendhal-1.16/doc. I don't see how this can be used in place of "cp -R". Maybe I'm just using it wrong though. I'm going to upload and updated shar file with the fixes that I have made so far. I think I have followed all of your suggestions except for using "COPYTREE_*" macros and a "straightforward conditional" install. I will keep working on it.
Created attachment 154176 [details] r4: shell archive for games/stendhal Okay, I replaced the "cp -R" commands with "COPYTREE_SHARE" (thanks to some help from the users on #bsdports of the freenode.net IRC network). I changed the shell for loops on those lines to do as straightforward install as you suggested. Should I do that with the rest of the for loops?
I forgot to mention that I also added a couple manpage files.
Created attachment 154183 [details] r5: shell archive for games/stendhal I have removed all the for loops and replaced them with INSTALL_DATA macros. I hope I have done it all as was expected. Let me know if something isn't right or there is something more I need to do. Thank you, - Jordan
I just realized that I probably don't need to tick "patch" when submitting the shell archive files. Sorry about that.
I think I found a solution to the issue I was having building a separate Marauroa Port. Apparently Stendhal runs off Marauroa from a different Git branch. I will again attempt to create a separate Port for Marauroa, but it looks like the PR was deleted (may have done that myself as I think I may have marked it invalid or something) so I will create a new one.
A commit references this bug: Author: amdmi3 Date: Thu Apr 23 20:30:16 UTC 2015 New revision: 384608 URL: https://svnweb.freebsd.org/changeset/ports/384608 Log: Stendhal is an open source 2D MMORPG with an excellent community. Players can gain experience through battling, quest for special items, explore an expanding world or even be a part of the development. There are lots of ways to be involved in the project. Stendhal is developed using the Arianne game development system. WWW: https://stendhalgame.org/ PR: 196649 Submitted by: antumdeluge@gmail.com Changes: head/games/Makefile head/games/stendhal/ head/games/stendhal/Makefile head/games/stendhal/distinfo head/games/stendhal/files/ head/games/stendhal/files/patch-src_games_stendhal_server_core_engine_GenerateINI.java head/games/stendhal/files/stendhal head/games/stendhal/files/stendhal-server head/games/stendhal/files/stendhal-server.1 head/games/stendhal/files/stendhal.1 head/games/stendhal/files/stendhal.desktop head/games/stendhal/pkg-descr head/games/stendhal/pkg-plist