Bug 196691 - net/dpdk: Remove d_thread_t usage
Summary: net/dpdk: Remove d_thread_t usage
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks: 196544
  Show dependency tree / graph
 
Reported: 2015-01-13 19:10 UTC by John Baldwin
Modified: 2015-01-29 15:26 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (bruce.richardson)

Attachments
remove_d_thread_t.patch (1.25 KB, patch)
2015-01-13 19:10 UTC, John Baldwin 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Baldwin freebsd_committer freebsd_triage 2015-01-13 19:10:05 UTC 
Created attachment 151575 [details]
remove_d_thread_t.patch

The d_thread_t typedef is a compat shim to support FreeBSD 4.x.  I'm planning to remove this shim from 11 and dpdk is very unlikely to ever be ported to 4.x.  If it does it will need far more changes than just d_thread_t.

Port maintainer, can you also submit this change upstream?
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-01-13 19:10:05 UTC 
Maintainer CC'd
Comment 2 Bruce Richardson 2015-01-16 12:27:59 UTC 
Patch submitted to upstream dpdk.org project for inclusion in next DPDK release. Ref: http://dpdk.org/ml/archives/dev/2015-January/011098.html
Comment 3 John Baldwin freebsd_committer freebsd_triage 2015-01-16 15:34:46 UTC 
Thanks!  Are you ok with me committing this patch to the port in the meantime?
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-01-29 15:25:52 UTC 
A commit references this bug:

Author: jhb
Date: Thu Jan 29 15:25:37 UTC 2015
New revision: 378121
URL: https://svnweb.freebsd.org/changeset/ports/378121

Log:
  Replace 'd_thread_t' with 'struct thread'.  This patch has been accepted
  upstream.

  PR:		196691
  Approved by:	maintainer

Changes:
  head/net/dpdk/files/
  head/net/dpdk/files/patch-lib-librte_eal-bsdapp-nic_uio-nic_uio.c