Bug 196923 - [maintainer update] sysutils/backuppc-devel: fix shebang, pkg-plist cleanup
Summary: [maintainer update] sysutils/backuppc-devel: fix shebang, pkg-plist cleanup
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: John Marino
URL:
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2015-01-20 08:26 UTC by Alexander Moisseev
Modified: 2015-02-06 09:47 UTC (History)
2 users (show)

See Also:

Attachments
patch (2.04 KB, patch)
2015-01-20 08:26 UTC, Alexander Moisseev 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Moisseev 2015-01-20 08:26:17 UTC 
Created attachment 151889 [details]
patch

- Fix Perl path in shebang
- Remove @sample macros from pkg-plist
   .sample files actually are templates for the configuration script
   and should not be installed as working configuration files.
- pkg-plist cleanup
Comment 1 John Marino freebsd_committer freebsd_triage 2015-01-20 19:28:43 UTC 
I would have liked to have seen a poudriere log, but this port's version did not change and the changes look reasonable.  I'll take a small risk and promote it to "patch-ready" status as untested.
Comment 2 John Marino freebsd_committer freebsd_triage 2015-02-06 09:44:05 UTC 
it passes poudriere.

portlint comes up with:
WARN: Makefile: possible use of absolute pathname "/var/db/BackupPC".
WARN: Makefile: "RUN_DEPENDS" has to appear earlier.


I would have liked to see the RUN_DEPENDS warning addressed, but I'll accept the patch as it is.
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-02-06 09:45:46 UTC 
A commit references this bug:

Author: marino
Date: Fri Feb  6 09:44:49 UTC 2015
New revision: 378517
URL: https://svnweb.freebsd.org/changeset/ports/378517

Log:
  sysutils/backuppc-devel: Fix shebang, sample files, pkg-plist

  PR:		196923
  Submitted by:	maintainer (Alexander Moisseev)

Changes:
  head/sysutils/backuppc-devel/Makefile
  head/sysutils/backuppc-devel/files/update.sh.in
  head/sysutils/backuppc-devel/pkg-plist
Comment 4 John Marino freebsd_committer freebsd_triage 2015-02-06 09:47:39 UTC 
Thanks!