Bug 197036 - [patch] net/quagga make rc script conform to the Porter's Handbook guidelines
Summary: [patch] net/quagga make rc script conform to the Porter's Handbook guidelines
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mathieu Arnold
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-23 20:39 UTC by Serhii (Sergey) Kozlov
Modified: 2015-02-17 14:55 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (mat)

Attachments
The Patch (2.49 KB, patch)
2015-01-23 20:39 UTC, Serhii (Sergey) Kozlov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Serhii (Sergey) Kozlov freebsd_committer freebsd_triage 2015-01-23 20:39:05 UTC 
Created attachment 152060 [details]
The Patch

Fix following bugs in rc script:
1. The "-d" flag must be in command_args, not the name_flags (Porter's Handbook 6.26.1.12)
2. Make the while loop related to quagga_wait_for finite (Porter's Handbook 6.26.1.16)
3. Make cosmetic changes to the variable's alignment in comments on the top
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-01-23 20:39:05 UTC 
Auto-assigned to maintainer mat@FreeBSD.org
Comment 2 Mathieu Arnold freebsd_committer freebsd_triage 2015-02-17 13:51:53 UTC 
Mmmm, I'm really not sure 5 seconds is enough.  When using BGP, many routers won't send their routes before 30 or 60 seconds after the session is up in order to reduce flapping.
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-02-17 14:26:11 UTC 
A commit references this bug:

Author: mat
Date: Tue Feb 17 14:25:24 UTC 2015
New revision: 379163
URL: https://svnweb.freebsd.org/changeset/ports/379163

Log:
  Make quagga's rc script conform to the porter's handbook guidelines.

  PR:		197036
  Submitted by:	Kozlov Sergey
  Sponsored by:	Absolight

Changes:
  head/net/quagga/Makefile
  head/net/quagga/files/quagga.in