Bug 197471 - [MAINTAINER] security/p5-openxpki-i18n: Update to 0.26.1.1
Summary: [MAINTAINER] security/p5-openxpki-i18n: Update to 0.26.1.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: John Marino
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-02-08 22:22 UTC by Sergei Vyshenski
Modified: 2015-03-01 22:32 UTC (History)
2 users (show)

See Also:

Attachments
patch for updating port (1.28 KB, patch)
2015-02-08 22:22 UTC, Sergei Vyshenski 		koobs: maintainer-approval+
Details | Diff
log from poudriere at 10.1-amd64 (18.62 KB, text/plain)
2015-02-08 22:22 UTC, Sergei Vyshenski 		no flags Details
patch for updating port (1.47 KB, patch)
2015-02-16 20:53 UTC, Sergei Vyshenski 		koobs: maintainer-approval+
Details | Diff
log from poudriere at 10.1-amd64 (18.48 KB, text/plain)
2015-02-16 20:53 UTC, Sergei Vyshenski 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergei Vyshenski 2015-02-08 22:22:07 UTC 
Created attachment 152783 [details]
patch for updating port

- Update to ver 0.26.1.1
Changes: https://github.com/openxpki/openxpki/commits/master

- "portlint -AC" says:
WARN: /usr/ports/security/p5-openxpki-i18n/pkg-plist: There are only 4 items in the plist.  Consider using PLIST_FILES instead of pkg-plist when installing less than 6 items.
WARN: Makefile: Consider adding support for a NLS knob to conditionally disable gettext support.
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: using hyphen in PORTNAME. consider using PKGNAMEPREFIX and/or PKGNAMESUFFIX.
0 fatal errors and 4 warnings found.

Please note that we can not go without gettext, i18n is needed here even for English.

- Tested with poudriere (log attached) at 10.1-amd64 with perl5-5.18.4_11
Comment 1 Sergei Vyshenski 2015-02-08 22:22:33 UTC 
Created attachment 152784 [details]
log from poudriere at 10.1-amd64
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2015-02-16 04:15:59 UTC 
Comment on attachment 152783 [details]
patch for updating port

Thanks for your submission Sergei. 

Minor review items:

Should be able to use PKGNAMESUFFIX for -i18n, will allow you to remove DISTNAME override, and GH_PROJECT, which defaults to PORTNAME.
Comment 3 Sergei Vyshenski 2015-02-16 20:53:19 UTC 
Created attachment 153083 [details]
patch for updating port

This time make use of PKGNAMESUFFIX=-i18n
Thanks for the tip.
Comment 4 Sergei Vyshenski 2015-02-16 20:53:49 UTC 
Created attachment 153084 [details]
log from poudriere at 10.1-amd64
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-03-01 22:31:55 UTC 
A commit references this bug:

Author: marino
Date: Sun Mar  1 22:31:24 UTC 2015
New revision: 380232
URL: https://svnweb.freebsd.org/changeset/ports/380232

Log:
  security/p5-openxpki-i18n: Upgrade version 0.25.0.1 => 0.26.1.1

  PR:		197471
  Submitted by:	maintainer (Sergei Vyshenski)

Changes:
  head/security/p5-openxpki-i18n/Makefile
  head/security/p5-openxpki-i18n/distinfo
Comment 6 John Marino freebsd_committer freebsd_triage 2015-03-01 22:32:33 UTC 
Thanks!